From 58e0aa5f8fb2344b44021e4d27d48eca26354715 Mon Sep 17 00:00:00 2001 From: Vitor Pamplona Date: Sat, 4 Mar 2023 10:49:36 -0500 Subject: [PATCH] Fixing relative paths on OG:IMAGE tags to correctly see a preview card --- app/build.gradle | 2 +- .../amethyst/ui/components/UrlPreviewCard.kt | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 4c2169e58..950a14222 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -103,7 +103,7 @@ dependencies { implementation 'androidx.security:security-crypto-ktx:1.1.0-alpha05' // view videos - implementation 'com.google.android.exoplayer:exoplayer:2.18.3' + implementation 'com.google.android.exoplayer:exoplayer:2.18.4' // Load images from the web. implementation "io.coil-kt:coil-compose:2.2.2" diff --git a/app/src/main/java/com/vitorpamplona/amethyst/ui/components/UrlPreviewCard.kt b/app/src/main/java/com/vitorpamplona/amethyst/ui/components/UrlPreviewCard.kt index 98ca76a9d..52e039070 100644 --- a/app/src/main/java/com/vitorpamplona/amethyst/ui/components/UrlPreviewCard.kt +++ b/app/src/main/java/com/vitorpamplona/amethyst/ui/components/UrlPreviewCard.kt @@ -21,6 +21,7 @@ import androidx.compose.ui.unit.dp import coil.compose.AsyncImage import com.baha.url.preview.UrlInfoItem import com.vitorpamplona.amethyst.R +import java.net.URL @Composable fun UrlPreviewCard( @@ -36,8 +37,14 @@ fun UrlPreviewCard( .border(1.dp, MaterialTheme.colors.onSurface.copy(alpha = 0.12f), RoundedCornerShape(15.dp)) ) { Column { + // correctly treating relative images + val imageUrl = if (previewInfo.image.startsWith("/")) + URL(URL(previewInfo.url), previewInfo.image).toString() + else + previewInfo.image + AsyncImage( - model = previewInfo.image, + model = imageUrl, contentDescription = stringResource(R.string.preview_card_image_for, url), contentScale = ContentScale.FillWidth, modifier = Modifier.fillMaxWidth()