From bc6d5060cb327deeaabaa064ff5ff1573892d02e Mon Sep 17 00:00:00 2001 From: Vitor Pamplona Date: Wed, 17 Jul 2024 09:09:19 -0400 Subject: [PATCH] Moves frame dropping logs from 20ms to 33ms give than many videos make the UI run at 30fps --- .../src/main/java/com/vitorpamplona/amethyst/LogMonitor.kt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/LogMonitor.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/LogMonitor.kt index 3967cc373..4c5f4250a 100644 --- a/amethyst/src/main/java/com/vitorpamplona/amethyst/LogMonitor.kt +++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/LogMonitor.kt @@ -183,7 +183,8 @@ object ChoreographerHelper { return } val diff = (frameTimeNanos - lastFrameTimeNanos) / 1000000 - if (diff > 20) { + // only report after 30ms because videos play at 30fps + if (diff > 35) { // Follow the frame number val droppedCount = (diff / 16.6).toInt() Log.w("block-canary", "Dropped $droppedCount frames. Skipped $diff ms")