From bd2005ec6e9a71ee0cf7c971ea6a1c762ef79c66 Mon Sep 17 00:00:00 2001
From: Vitor Pamplona <vitor@vitorpamplona.com>
Date: Fri, 29 Nov 2024 16:40:07 -0500
Subject: [PATCH] Fixes screen mispositioning when rotating full screen
 video/image dialogs.

---
 .../ui/components/ZoomableContentDialog.kt    | 40 +++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ZoomableContentDialog.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ZoomableContentDialog.kt
index 0ce50701c..0e12d7e38 100644
--- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ZoomableContentDialog.kt
+++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ZoomableContentDialog.kt
@@ -54,7 +54,6 @@ import androidx.compose.material3.Surface
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.MutableState
-import androidx.compose.runtime.SideEffect
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
@@ -106,7 +105,7 @@ fun ZoomableImageDialog(
         onDismissRequest = onDismiss,
         properties =
             DialogProperties(
-                usePlatformDefaultWidth = true,
+                usePlatformDefaultWidth = false,
                 decorFitsSystemWindows = false,
             ),
     ) {
@@ -118,27 +117,26 @@ fun ZoomableImageDialog(
         val activityWindow = getActivityWindow()
         val dialogWindow = getDialogWindow()
         val parentView = LocalView.current.parent as View
-        SideEffect {
-            if (activityWindow != null && dialogWindow != null) {
-                val attributes = WindowManager.LayoutParams()
-                attributes.copyFrom(activityWindow.attributes)
-                attributes.type = dialogWindow.attributes.type
-                dialogWindow.attributes = attributes
-                parentView.layoutParams =
-                    FrameLayout.LayoutParams(
-                        activityWindow.decorView.width,
-                        activityWindow.decorView.height,
-                    )
-                view.layoutParams =
-                    FrameLayout.LayoutParams(
-                        activityWindow.decorView.width,
-                        activityWindow.decorView.height,
-                    )
-            }
+
+        if (activityWindow != null && dialogWindow != null) {
+            val attributes = WindowManager.LayoutParams()
+            attributes.copyFrom(activityWindow.attributes)
+            attributes.type = dialogWindow.attributes.type
+            dialogWindow.attributes = attributes
+            parentView.layoutParams =
+                FrameLayout.LayoutParams(
+                    activityWindow.decorView.width,
+                    activityWindow.decorView.height,
+                )
+            view.layoutParams =
+                FrameLayout.LayoutParams(
+                    activityWindow.decorView.width,
+                    activityWindow.decorView.height,
+                )
         }
 
-        Surface(modifier = Modifier.fillMaxSize()) {
-            Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.TopCenter) {
+        Surface(Modifier.fillMaxSize()) {
+            Box(Modifier.fillMaxSize(), Alignment.TopCenter) {
                 DialogContent(allImages, imageUrl, onDismiss, accountViewModel)
             }
         }