From 0238aebf619013a761c06ad3c57a56ee50f4541c Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Mon, 3 Aug 2026 17:20:08 +0100 Subject: [PATCH] refactor: Annotate `MakeAndPushFeature` with `[[maybe_unused]]` This is a follow-up to bitcoin/bitcoin#35221. The `MakeAndPushFeature` member function template has no callers yet, which triggers `-Wunused-template` now that Clang 23 enables it as part of `-Wall`. --- src/net_processing.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 03e5c90b491..b0c2a441455 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -804,7 +804,7 @@ private: m_connman.PushMessage(&node, NetMsg::Make(std::move(msg_type), std::forward(args)...)); } template - void MakeAndPushFeature(CNode& node, std::string_view feature_id, Args&&... args) const + [[maybe_unused]] void MakeAndPushFeature(CNode& node, std::string_view feature_id, Args&&... args) const { if (!Assume(feature_id.size() >= 4 && feature_id.size() <= MAX_FEATUREID_LENGTH)) return; std::vector feature_data;