From 0465574c127907df9b764055a585e8281bae8d1d Mon Sep 17 00:00:00 2001 From: Sergi Delgado Segura Date: Fri, 20 Jun 2025 10:56:26 -0400 Subject: [PATCH] test: Fixes send_blocks_and_test docs It's not true that if success=False the tip doesn't advance. It doesn'test advance to the provided tip, but it can advance to a competing one --- test/functional/test_framework/p2p.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/functional/test_framework/p2p.py b/test/functional/test_framework/p2p.py index 610aa4ccca2..7aacf66d463 100755 --- a/test/functional/test_framework/p2p.py +++ b/test/functional/test_framework/p2p.py @@ -866,8 +866,8 @@ class P2PDataStore(P2PInterface): - the on_getheaders handler will ensure that any getheaders are responded to - if force_send is False: wait for getdata for each of the blocks. The on_getdata handler will ensure that any getdata messages are responded to. Otherwise send the full block unsolicited. - - if success is True: assert that the node's tip advances to the most recent block - - if success is False: assert that the node's tip doesn't advance + - if success is True: assert that the node's tip is the last block in blocks at the end of the operation. + - if success is False: assert that the node's tip isn't the last block in blocks at the end of the operation - if reject_reason is set: assert that the correct reject message is logged""" with p2p_lock: