From 4b7b58b3fef5b9566a475871c441ed6ae73af89e Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Mon, 7 Dec 2020 19:23:16 +0100 Subject: [PATCH] Update net_processing WTXID documentation per BIP339 as BIP339 currently states: "The wtxidrelay message MUST be sent in response to a version message from a peer whose protocol version is >= 70016 and prior to sending a verack. A wtxidrelay message received after a verack message MUST be ignored or treated as invalid." --- src/net_processing.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 1b4a05f0b66..3600ac7c629 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -2516,8 +2516,8 @@ void PeerManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, CDat return; } - // Feature negotiation of wtxidrelay should happen between VERSION and - // VERACK, to avoid relay problems from switching after a connection is up + // Feature negotiation of wtxidrelay must happen between VERSION and VERACK + // to avoid relay problems from switching after a connection is up. if (msg_type == NetMsgType::WTXIDRELAY) { if (pfrom.fSuccessfullyConnected) { // Disconnect peers that send wtxidrelay message after VERACK; this