From 1137debb85306063f1660bc15850979e7db88fb8 Mon Sep 17 00:00:00 2001 From: ismaelsadeeq Date: Wed, 21 Jan 2026 20:08:07 +0000 Subject: [PATCH] doc: mempool: fix `removeUnchecked` incorrect comment - CTxMemPool::removeUnchecked description comment is stale and incorrect after cluster mempool. This commit fixes the issue by deleting the stale comment and describing only the implicit behaviour triggered by the method. --- src/txmempool.h | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/txmempool.h b/src/txmempool.h index bef711d4c71..996a1fe081e 100644 --- a/src/txmempool.h +++ b/src/txmempool.h @@ -589,14 +589,7 @@ private: /* Helper for the public removeRecursive() */ void removeRecursive(txiter to_remove, MemPoolRemovalReason reason) EXCLUSIVE_LOCKS_REQUIRED(cs); - /** Before calling removeUnchecked for a given transaction, - * UpdateForRemoveFromMempool must be called on the entire (dependent) set - * of transactions being removed at the same time. We use each - * CTxMemPoolEntry's m_parents in order to walk ancestors of a - * given transaction that is removed, so we can't remove intermediate - * transactions in a chain before we've updated all the state for the - * removal. - */ + /* Removal from the mempool also triggers removal of the entry's Ref from txgraph. */ void removeUnchecked(txiter entry, MemPoolRemovalReason reason) EXCLUSIVE_LOCKS_REQUIRED(cs); public: /** visited marks a CTxMemPoolEntry as having been traversed