From 141117f5e8b41eb27539d217aa4e6c407c067d90 Mon Sep 17 00:00:00 2001 From: Andrew Toth Date: Thu, 13 Nov 2025 09:37:55 -0500 Subject: [PATCH] refactor: remove incorrect LIFETIMEBOUND annotations The return value of CheckBlockDataAvailability does not extend the lifetime of the input parameters, nor does BlockManager instance retain references to the parameters. The LIFETIMEBOUND annotations are misleading here since the lifetime of the parameters are not extended past the method call. --- src/node/blockstorage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/blockstorage.h b/src/node/blockstorage.h index d5da95c7a7d..9a6199193e2 100644 --- a/src/node/blockstorage.h +++ b/src/node/blockstorage.h @@ -402,7 +402,7 @@ public: //! Check if all blocks in the [upper_block, lower_block] range have data available. //! The caller is responsible for ensuring that lower_block is an ancestor of upper_block //! (part of the same chain). - bool CheckBlockDataAvailability(const CBlockIndex& upper_block LIFETIMEBOUND, const CBlockIndex& lower_block LIFETIMEBOUND) EXCLUSIVE_LOCKS_REQUIRED(::cs_main); + bool CheckBlockDataAvailability(const CBlockIndex& upper_block, const CBlockIndex& lower_block) EXCLUSIVE_LOCKS_REQUIRED(::cs_main); /** * @brief Returns the earliest block with specified `status_mask` flags set after