From e325e0fccba4981d28053b79473ddaa44355e6e8 Mon Sep 17 00:00:00 2001 From: willcl-ark Date: Mon, 30 Jan 2023 10:24:59 +0000 Subject: [PATCH 1/2] doc: Fix comment syntax error --- src/kernel/mempool_options.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kernel/mempool_options.h b/src/kernel/mempool_options.h index a5a0bae86d1..beb5fca5e9a 100644 --- a/src/kernel/mempool_options.h +++ b/src/kernel/mempool_options.h @@ -18,7 +18,7 @@ class CBlockPolicyEstimator; /** Default for -maxmempool, maximum megabytes of mempool memory usage */ static constexpr unsigned int DEFAULT_MAX_MEMPOOL_SIZE_MB{300}; -//** Default for -maxmempool when blocksonly is set */ +/** Default for -maxmempool when blocksonly is set */ static constexpr unsigned int DEFAULT_BLOCKSONLY_MAX_MEMPOOL_SIZE_MB{5}; /** Default for -mempoolexpiry, expiration time for mempool transactions in hours */ static constexpr unsigned int DEFAULT_MEMPOOL_EXPIRY_HOURS{336}; From 47c174d8ce4c5f36c41203aedde86c5f0da90217 Mon Sep 17 00:00:00 2001 From: willcl-ark Date: Mon, 30 Jan 2023 10:24:22 +0000 Subject: [PATCH 2/2] doc: NetPermissionFlags for tx relay in blocksonly Detail which permission type enables transaction relay for nodes connected in blockonly mode --- doc/reduce-memory.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/reduce-memory.md b/doc/reduce-memory.md index 097cc9f0010..25205258b84 100644 --- a/doc/reduce-memory.md +++ b/doc/reduce-memory.md @@ -18,7 +18,7 @@ The size of some in-memory caches can be reduced. As caches trade off memory usa - Since `0.14.0`, unused memory allocated to the mempool (default: 300MB) is shared with the UTXO cache, so when trying to reduce memory usage you should limit the mempool, with the `-maxmempool` command line argument. -- To disable most of the mempool functionality there is the `-blocksonly` option. This will reduce the default memory usage to 5MB and make the client opt out of receiving (and thus relaying) transactions, except from whitelisted peers and as part of blocks. +- To disable most of the mempool functionality there is the `-blocksonly` option. This will reduce the default memory usage to 5MB and make the client opt out of receiving (and thus relaying) transactions, except from peers who have the `relay` permission set (e.g. whitelisted peers), and as part of blocks. - Do not use this when using the client to broadcast transactions as any transaction sent will stick out like a sore thumb, affecting privacy. When used with the wallet it should be combined with `-walletbroadcast=0` and `-spendzeroconfchange=0`. Another mechanism for broadcasting outgoing transactions (if any) should be used.