From 1ed8e7616527c69dbaa9904cda59e3b73c29fa5d Mon Sep 17 00:00:00 2001 From: rkrux Date: Thu, 12 Jun 2025 20:19:04 +0530 Subject: [PATCH] rpc, doc: clarify the response of listtransactions RPC I noticed this behaviour while perf testing PR 27286 and it was not something that I expected, updating the doc to make it present in the RPCHelp command. --- src/wallet/rpc/transactions.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/wallet/rpc/transactions.cpp b/src/wallet/rpc/transactions.cpp index 3580d2ceb06..e76d38c97ab 100644 --- a/src/wallet/rpc/transactions.cpp +++ b/src/wallet/rpc/transactions.cpp @@ -444,7 +444,11 @@ RPCHelpMan listtransactions() return RPCHelpMan{ "listtransactions", "If a label name is provided, this will return only incoming transactions paying to addresses with the specified label.\n" - "\nReturns up to 'count' most recent transactions skipping the first 'from' transactions.\n", + "Returns up to 'count' most recent transactions ordered from oldest to newest while skipping the first number of \n" + "transactions specified in the 'skip' argument. A transaction can have multiple entries in this RPC response. \n" + "For instance, a wallet transaction that pays three addresses — one wallet-owned and two external — will produce \n" + "four entries. The payment to the wallet-owned address appears both as a send entry and as a receive entry. \n" + "As a result, the RPC response will contain one entry in the receive category and three entries in the send category.\n", { {"label", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "If set, should be a valid label name to return only incoming transactions\n" "with the specified label, or \"*\" to disable filtering and return all transactions."},