From 35839e963bf61d2da0d12f5b8cea74ac0e0fbd7b Mon Sep 17 00:00:00 2001
From: Amiti Uttarwar <amiti@uttarwar.org>
Date: Tue, 2 Jun 2020 09:01:36 -0700
Subject: [PATCH] [net] Fix bug where AddrFetch connections would be counted as
 outbound full relay

The desired logic is for us to only open feeler connections after we have hit
the max count for outbound full relay connections.  A short lived AddrFetch
connection (previously called oneshot) could cause ThreadOpenConnections to
miscount and mistakenly open a feeler instead of full relay.
---
 src/net.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/net.cpp b/src/net.cpp
index 67db02d0a17..f2dcec784fc 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -1841,7 +1841,7 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
                     setConnected.insert(pnode->addr.GetGroup(addrman.m_asmap));
                     if (pnode->m_tx_relay == nullptr) {
                         nOutboundBlockRelay++;
-                    } else if (!pnode->IsFeelerConn()) {
+                    } else if (pnode->m_conn_type == ConnectionType::OUTBOUND) {
                         nOutboundFullRelay++;
                     }
                 }