From 3c2920ec98fc7d9f77abfd08fea17211b9ca7099 Mon Sep 17 00:00:00 2001 From: Ryan Ofsky Date: Thu, 19 Dec 2019 18:00:04 -0500 Subject: [PATCH] refactor: Avoid using IsArgSet() on -signetseednode and -signetchallenge list options This commit does not change behavior because negation of -signetseednode and -signetchallenge parameters has been disallowed since these were introduced in #18267, so calling IsArgSet() is equivalent to checking if GetArgs() returns a non-empty list. --- src/chainparams.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/chainparams.cpp b/src/chainparams.cpp index 3da02f323c7..7cf28d69b42 100644 --- a/src/chainparams.cpp +++ b/src/chainparams.cpp @@ -25,10 +25,10 @@ using util::SplitString; void ReadSigNetArgs(const ArgsManager& args, CChainParams::SigNetOptions& options) { - if (args.IsArgSet("-signetseednode")) { + if (!args.GetArgs("-signetseednode").empty()) { options.seeds.emplace(args.GetArgs("-signetseednode")); } - if (args.IsArgSet("-signetchallenge")) { + if (!args.GetArgs("-signetchallenge").empty()) { const auto signet_challenge = args.GetArgs("-signetchallenge"); if (signet_challenge.size() != 1) { throw std::runtime_error("-signetchallenge cannot be multiple values.");