From 3f44f9aef7ccd0417fcd0c2f33f20615ea5c11e6 Mon Sep 17 00:00:00 2001 From: marcofleon Date: Mon, 27 Apr 2026 19:15:46 +0100 Subject: [PATCH] test: Add coverage for m_blocks_unlinked invariant in LoadBlockIndex A pruned stale-fork block whose parent doesn't have any transactions shouldn't be added to m_blocks_unlinked when starting up a node. --- test/functional/feature_prune_stale_fork.py | 39 +++++++++++++++++++++ test/functional/test_runner.py | 1 + 2 files changed, 40 insertions(+) create mode 100755 test/functional/feature_prune_stale_fork.py diff --git a/test/functional/feature_prune_stale_fork.py b/test/functional/feature_prune_stale_fork.py new file mode 100755 index 00000000000..5badca0a7cf --- /dev/null +++ b/test/functional/feature_prune_stale_fork.py @@ -0,0 +1,39 @@ +#!/usr/bin/env python3 +# Copyright (c) 2026-present The Bitcoin Core developers +# Distributed under the MIT software license, see the accompanying +# file COPYING or http://www.opensource.org/licenses/mit-license.php. +"""Test node restart with a pruned stale-fork block whose parent has no transactions.""" + +from test_framework.blocktools import create_empty_fork +from test_framework.test_framework import BitcoinTestFramework +from test_framework.util import assert_equal, assert_raises_rpc_error + + +class FeaturePruneStaleForkTest(BitcoinTestFramework): + def set_test_params(self): + self.num_nodes = 1 + self.extra_args = [["-prune=1", "-fastprune"]] + + def run_test(self): + node = self.nodes[0] + + self.log.info("Create a 2-block stale fork: parent has no transactions, child has transactions") + [side_parent, side_child] = create_empty_fork(node, 2) + + node.submitheader(side_parent.serialize().hex()) + node.submitblock(side_child.serialize().hex()) + assert_equal(node.getblockheader(side_parent.hash_hex)["nTx"], 0) + assert_equal(node.getblockheader(side_child.hash_hex)["nTx"], 1) + + self.log.info("Advance and prune so the stale-fork child's block data is removed from disk") + self.generate(node, 500) + node.pruneblockchain(node.getblockcount() - 100) + assert_raises_rpc_error(-1, "Block not available (pruned data)", node.getblock, side_child.hash_hex) + + self.log.info("Restart and mine; node must reload cleanly after the stale-fork child was pruned") + self.restart_node(0) + self.generate(node, 1) + + +if __name__ == '__main__': + FeaturePruneStaleForkTest(__file__).main() diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index 698742bc79e..9236f3a90d3 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -369,6 +369,7 @@ BASE_SCRIPTS = [ 'feature_blocksdir.py', 'wallet_startup.py', 'feature_remove_pruned_files_on_startup.py', + 'feature_prune_stale_fork.py', 'p2p_i2p_ports.py', 'p2p_i2p_sessions.py', 'feature_presegwit_node_upgrade.py',