From 47915b118720c6e2b2ec9f599f25848041b42b99 Mon Sep 17 00:00:00 2001 From: Sebastian Falbesoner Date: Sat, 19 Jun 2021 22:42:08 +0200 Subject: [PATCH] test: remove unneeded/redundant code in wallet_listtransactions -> remove unneeded get-out-of IBD generate() (The test framework already sets up the nodes to be out of IBD in setup_nodes(), if setup_clean_chain is not set to True) -> remove duplicate code line assigning an utxo --- test/functional/wallet_listtransactions.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/functional/wallet_listtransactions.py b/test/functional/wallet_listtransactions.py index df1cbd5eded..7557dbe8c8d 100755 --- a/test/functional/wallet_listtransactions.py +++ b/test/functional/wallet_listtransactions.py @@ -26,8 +26,6 @@ class ListTransactionsTest(BitcoinTestFramework): self.skip_if_no_wallet() def run_test(self): - self.nodes[0].generate(1) # Get out of IBD - self.sync_all() # Simple send, 0 to 1: txid = self.nodes[0].sendtoaddress(self.nodes[1].getnewaddress(), 0.1) self.sync_all() @@ -136,7 +134,6 @@ class ListTransactionsTest(BitcoinTestFramework): utxo_to_use = get_unconfirmed_utxo_entry(self.nodes[0], txid_1) assert_equal(utxo_to_use["safe"], True) utxo_to_use = get_unconfirmed_utxo_entry(self.nodes[1], txid_1) - utxo_to_use = get_unconfirmed_utxo_entry(self.nodes[1], txid_1) assert_equal(utxo_to_use["safe"], False) # Create tx2 using createrawtransaction