From 5155602a636c323424f75272ccec38588b3d71cd Mon Sep 17 00:00:00 2001 From: JamesC Date: Thu, 31 Oct 2019 12:01:58 +0100 Subject: [PATCH] Move argparse() to init() This ensures TestFramework default parameters are set before setup is called. A child class will therefore have access to defaults when overriding setup. --- test/functional/test_framework/test_framework.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py index 7375ab1fb75..c56c0d06ffd 100755 --- a/test/functional/test_framework/test_framework.py +++ b/test/functional/test_framework/test_framework.py @@ -99,14 +99,13 @@ class BitcoinTestFramework(metaclass=BitcoinTestMetaClass): self.supports_cli = False self.bind_to_localhost_only = True self.set_test_params() + self.parse_args() def main(self): """Main function. This should not be overridden by the subclass test scripts.""" assert hasattr(self, "num_nodes"), "Test must set self.num_nodes in set_test_params()" - self.parse_args() - try: self.setup() self.run_test()