From 5b088859863224a94514c78ea841d7314ec8fa50 Mon Sep 17 00:00:00 2001 From: Martin Zumsande Date: Wed, 30 Apr 2025 11:46:12 -0400 Subject: [PATCH] test: enable functional tests with large rpc args for cli Also, the following tests (for which self.supports_cli = False was not set) will now work with --usecli: feature_fastprune.py feature_fee_estimation.py feature_reindex_readonly.py feature_taproot.py mempool_package_rbf.py p2p_net_deadlock.py p2p_tx_download.py rpc_packages.py --- test/functional/feature_maxuploadtarget.py | 1 - test/functional/feature_pruning.py | 1 - test/functional/mempool_limit.py | 1 - test/functional/mining_basic.py | 1 - test/functional/p2p_1p1c_network.py | 1 - test/functional/p2p_opportunistic_1p1c.py | 1 - test/functional/p2p_segwit.py | 1 - test/functional/wallet_taproot.py | 1 - 8 files changed, 8 deletions(-) diff --git a/test/functional/feature_maxuploadtarget.py b/test/functional/feature_maxuploadtarget.py index b72090b4363..526f2ffa904 100755 --- a/test/functional/feature_maxuploadtarget.py +++ b/test/functional/feature_maxuploadtarget.py @@ -52,7 +52,6 @@ class MaxUploadTest(BitcoinTestFramework): self.extra_args = [[ f"-maxuploadtarget={UPLOAD_TARGET_MB}M", ]] - self.supports_cli = False def assert_uploadtarget_state(self, *, target_reached, serve_historical_blocks): """Verify the node's current upload target state via the `getnettotals` RPC call.""" diff --git a/test/functional/feature_pruning.py b/test/functional/feature_pruning.py index f5536027ebb..bedfceee576 100755 --- a/test/functional/feature_pruning.py +++ b/test/functional/feature_pruning.py @@ -69,7 +69,6 @@ class PruneTest(BitcoinTestFramework): def set_test_params(self): self.setup_clean_chain = True self.num_nodes = 6 - self.supports_cli = False self.uses_wallet = None # Create nodes 0 and 1 to mine. diff --git a/test/functional/mempool_limit.py b/test/functional/mempool_limit.py index b9ee6a0a102..7c89dd98a75 100755 --- a/test/functional/mempool_limit.py +++ b/test/functional/mempool_limit.py @@ -31,7 +31,6 @@ class MempoolLimitTest(BitcoinTestFramework): self.extra_args = [[ "-maxmempool=5", ]] - self.supports_cli = False def test_rbf_carveout_disallowed(self): node = self.nodes[0] diff --git a/test/functional/mining_basic.py b/test/functional/mining_basic.py index 680c132b98b..53cb42f837a 100755 --- a/test/functional/mining_basic.py +++ b/test/functional/mining_basic.py @@ -65,7 +65,6 @@ class MiningTest(BitcoinTestFramework): ["-fastprune", "-prune=1"] ] self.setup_clean_chain = True - self.supports_cli = False def mine_chain(self): self.log.info('Create some old blocks') diff --git a/test/functional/p2p_1p1c_network.py b/test/functional/p2p_1p1c_network.py index b098e4cf436..fbf242a06c8 100755 --- a/test/functional/p2p_1p1c_network.py +++ b/test/functional/p2p_1p1c_network.py @@ -43,7 +43,6 @@ class PackageRelayTest(BitcoinTestFramework): self.extra_args = [[ "-maxmempool=5", ]] * self.num_nodes - self.supports_cli = False def raise_network_minfee(self): fill_mempool(self, self.nodes[0]) diff --git a/test/functional/p2p_opportunistic_1p1c.py b/test/functional/p2p_opportunistic_1p1c.py index 267a878323d..fd955d86d7e 100755 --- a/test/functional/p2p_opportunistic_1p1c.py +++ b/test/functional/p2p_opportunistic_1p1c.py @@ -61,7 +61,6 @@ class PackageRelayTest(BitcoinTestFramework): self.extra_args = [[ "-maxmempool=5", ]] - self.supports_cli = False def create_tx_below_mempoolminfee(self, wallet): """Create a 1-input 1sat/vB transaction using a confirmed UTXO. Decrement and use diff --git a/test/functional/p2p_segwit.py b/test/functional/p2p_segwit.py index 0892d9d1a48..d2790f03828 100755 --- a/test/functional/p2p_segwit.py +++ b/test/functional/p2p_segwit.py @@ -221,7 +221,6 @@ class SegWitTest(BitcoinTestFramework): ["-acceptnonstdtxn=1", f"-testactivationheight=segwit@{SEGWIT_HEIGHT}", "-par=1"], ["-acceptnonstdtxn=0", f"-testactivationheight=segwit@{SEGWIT_HEIGHT}"], ] - self.supports_cli = False # Helper functions diff --git a/test/functional/wallet_taproot.py b/test/functional/wallet_taproot.py index 35cbf5666ed..35d2d791f8d 100755 --- a/test/functional/wallet_taproot.py +++ b/test/functional/wallet_taproot.py @@ -191,7 +191,6 @@ class WalletTaprootTest(BitcoinTestFramework): self.num_nodes = 2 self.setup_clean_chain = True self.extra_args = [['-keypool=100'], ['-keypool=100']] - self.supports_cli = False def skip_test_if_missing_module(self): self.skip_if_no_wallet()