From 1823766fc69a3d57767af11f182826533465f621 Mon Sep 17 00:00:00 2001
From: Jon Atack <jon@atack.com>
Date: Fri, 7 Jan 2022 13:10:18 +0100
Subject: [PATCH] refactor: add thread safety lock assertion to
 WriteBlockIndexDB()

The new helper function, BlockManager::WriteBlockIndexDB(),
has a thread safety lock annotation in its declaration but is
missing the corresponding run-time lock assertion in its definition.

Per doc/developer-notes.md: "Combine annotations in function
declarations with run-time asserts in function definitions."
---
 src/node/blockstorage.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/node/blockstorage.cpp b/src/node/blockstorage.cpp
index 8127ebd7695..50c30595675 100644
--- a/src/node/blockstorage.cpp
+++ b/src/node/blockstorage.cpp
@@ -340,6 +340,7 @@ void BlockManager::Unload()
 
 bool BlockManager::WriteBlockIndexDB()
 {
+    AssertLockHeld(::cs_main);
     std::vector<std::pair<int, const CBlockFileInfo*>> vFiles;
     vFiles.reserve(m_dirty_fileinfo.size());
     for (std::set<int>::iterator it = m_dirty_fileinfo.begin(); it != m_dirty_fileinfo.end();) {