From 6c525c2ec13109649f461da2b11d59b04b2733e5 Mon Sep 17 00:00:00 2001 From: rkrux Date: Tue, 28 Apr 2026 20:21:18 +0530 Subject: [PATCH] wallet: unfriend LegacyDataSPKM and DescriptorScriptPubKeyMan classes After PR 28333, `LegacyDataSPKM` doesn't need to use the private or protected members of `DescriptorScriptPubKeyMan` class such as `AddDescriptorKeyWithDB` and `TopUpWithDB`. Moreover, these two SPKMs are siblings that inherit from the common `ScriptPubKeyMan`. It seems reasonable to me that they are unfriended so that private members of one are not exposed to another unnecessarily. --- src/wallet/scriptpubkeyman.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/wallet/scriptpubkeyman.h b/src/wallet/scriptpubkeyman.h index 35a419396b1..89f15c8db1c 100644 --- a/src/wallet/scriptpubkeyman.h +++ b/src/wallet/scriptpubkeyman.h @@ -274,7 +274,6 @@ public: class DescriptorScriptPubKeyMan : public ScriptPubKeyMan { - friend class LegacyDataSPKM; private: using ScriptPubKeyMap = std::map; // Map of scripts to descriptor range index using PubKeyMap = std::map; // Map of pubkeys involved in scripts to descriptor range index