From 6248331b295c5540399cd7754e03a19c93b24318 Mon Sep 17 00:00:00 2001 From: Hodlinator <172445034+hodlinator@users.noreply.github.com> Date: Mon, 24 Aug 2026 21:11:16 +0200 Subject: [PATCH] qa: Switch to warning when skipping tests This is convention, see of example "except SkipTest" in test_framework.py. --- test/functional/feature_init.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/feature_init.py b/test/functional/feature_init.py index 4fa88bb200e..694404e3f91 100755 --- a/test/functional/feature_init.py +++ b/test/functional/feature_init.py @@ -336,7 +336,7 @@ class InitTest(BitcoinTestFramework): try: resource.setrlimit(resource.RLIMIT_NOFILE, (limit, hard)) except (ValueError, OSError): - self.log.info(f"Skipping rlimit test: cannot set soft limit (hard={hard})") + self.log.warning(f"Skipping rlimit test: cannot set soft limit (hard={hard})") return try: self.restart_node(1) @@ -348,7 +348,7 @@ class InitTest(BitcoinTestFramework): def init_rlimit_test(self): """Test that bitcoind starts correctly when the soft RLIMIT_NOFILE limit is RLIM_INFINITY.""" if self.RLIM_INFINITY is None: - self.log.info("Skipping: resource module not available") + self.log.warning("Skipping: resource module not available") return self.log.info("Testing node startup with RLIM_INFINITY fd limit") @@ -357,7 +357,7 @@ class InitTest(BitcoinTestFramework): def init_rlimit_large_test(self): """Test that bitcoind starts correctly when the soft RLIMIT_NOFILE limit is above INT_MAX.""" if self.RLIM_INFINITY is None: - self.log.info("Skipping: resource module not available") + self.log.warning("Skipping: resource module not available") return self.log.info("Testing node startup with fd limit above INT_MAX") @@ -399,7 +399,7 @@ class InitTest(BitcoinTestFramework): try: resource.setrlimit(resource.RLIMIT_NOFILE, (soft, soft)) except (ValueError, OSError): - self.log.info(f"Skipping rlimit test: cannot reduce hard limit (soft={soft}, hard={hard})") + self.log.warning(f"Skipping rlimit test: cannot reduce hard limit (soft={soft}, hard={hard})") return self.log.info("Checking that large -maxconnections setting gets adjusted for available file descriptors")