From 65bd3164fbb00afd7759626b8c2bf4df9643ee25 Mon Sep 17 00:00:00 2001 From: Sjors Provoost Date: Thu, 28 May 2026 11:37:19 +0200 Subject: [PATCH] mining: clarify test_block_validity comment The option defaults to true, so describe the intended exceptional use case as disabling validation for tests and benchmarks. Suggested in https://github.com/bitcoin/bitcoin/pull/33966#discussion_r3303387586 --- src/node/mining_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/mining_types.h b/src/node/mining_types.h index 9c4fbcbbafe..6e4eb82aa93 100644 --- a/src/node/mining_types.h +++ b/src/node/mining_types.h @@ -86,7 +86,7 @@ struct BlockCreateOptions { CScript coinbase_output_script{CScript() << OP_TRUE}; /** * Whether to call TestBlockValidity() at the end of CreateNewBlock(). - * Should only be used for tests / benchmarks. + * Should only be disabled for tests / benchmarks. */ bool test_block_validity{true}; };