From 73fb9ced563cdf59bfee9462025e32e73f08ecd1 Mon Sep 17 00:00:00 2001 From: sedited Date: Mon, 31 Aug 2026 16:23:58 +0200 Subject: [PATCH] rpc: Fix private key type in signrawtransactionwithkey It is base58, so shouldn't be qualified with STR_HEX. Similarly, signmessagewithprivkey also declares the argument as a STR. This fix is motivated by the OpenRPC dump, where fields tagged with STR_HEX are described with a restricting regex that would make its correct usage a violation against the unpatched schema. --- src/rpc/rawtransaction.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp index e9eae656b51..e5a4e0ff5ad 100644 --- a/src/rpc/rawtransaction.cpp +++ b/src/rpc/rawtransaction.cpp @@ -699,7 +699,7 @@ static RPCMethod signrawtransactionwithkey() {"hexstring", RPCArg::Type::STR, RPCArg::Optional::NO, "The transaction hex string"}, {"privkeys", RPCArg::Type::ARR, RPCArg::Optional::NO, "The base58-encoded private keys for signing", { - {"privatekey", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED, "private key in base58-encoding"}, + {"privatekey", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "private key in base58-encoding"}, }, }, {"prevtxs", RPCArg::Type::ARR, RPCArg::Optional::OMITTED, "The previous dependent transaction outputs",