mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-09 06:09:48 +02:00
[clang-tidy] Enable the misc-no-recursion check
Co-authored-by: stickies-v <stickies-v@protonmail.com> Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>
This commit is contained in:
@@ -253,6 +253,7 @@ bool CachedTxIsFromMe(const CWallet& wallet, const CWalletTx& wtx, const isminef
|
||||
return (CachedTxGetDebit(wallet, wtx, filter) > 0);
|
||||
}
|
||||
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
bool CachedTxIsTrusted(const CWallet& wallet, const CWalletTx& wtx, std::set<uint256>& trusted_parents)
|
||||
{
|
||||
AssertLockHeld(wallet.cs_wallet);
|
||||
|
||||
@@ -395,6 +395,7 @@ class DescribeWalletAddressVisitor
|
||||
public:
|
||||
const SigningProvider * const provider;
|
||||
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
void ProcessSubScript(const CScript& subscript, UniValue& obj) const
|
||||
{
|
||||
// Always present: script type and redeemscript
|
||||
@@ -445,6 +446,7 @@ public:
|
||||
return obj;
|
||||
}
|
||||
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
UniValue operator()(const ScriptHash& scripthash) const
|
||||
{
|
||||
UniValue obj(UniValue::VOBJ);
|
||||
@@ -465,6 +467,7 @@ public:
|
||||
return obj;
|
||||
}
|
||||
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
UniValue operator()(const WitnessV0ScriptHash& id) const
|
||||
{
|
||||
UniValue obj(UniValue::VOBJ);
|
||||
|
||||
@@ -854,6 +854,7 @@ enum class ScriptContext
|
||||
|
||||
// Analyse the provided scriptPubKey, determining which keys and which redeem scripts from the ImportData struct are needed to spend it, and mark them as used.
|
||||
// Returns an error string, or the empty string for success.
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
static std::string RecurseImportData(const CScript& script, ImportData& import_data, const ScriptContext script_ctx)
|
||||
{
|
||||
// Use Solver to obtain script type and parsed pubkeys or hashes:
|
||||
|
||||
@@ -97,6 +97,7 @@ bool HaveKeys(const std::vector<valtype>& pubkeys, const LegacyScriptPubKeyMan&
|
||||
//! @param recurse_scripthash whether to recurse into nested p2sh and p2wsh
|
||||
//! scripts or simply treat any script that has been
|
||||
//! stored in the keystore as spendable
|
||||
// NOLINTNEXTLINE(misc-no-recursion)
|
||||
IsMineResult IsMineInner(const LegacyScriptPubKeyMan& keystore, const CScript& scriptPubKey, IsMineSigVersion sigversion, bool recurse_scripthash=true)
|
||||
{
|
||||
IsMineResult ret = IsMineResult::NO;
|
||||
|
||||
Reference in New Issue
Block a user