validation: invert m_cached_finished_ibd to m_cached_is_ibd

Rename and invert the internal IBD latch so the cached value directly matches `IsInitialBlockDownload()` (true while in IBD, then latched to false).

This is a behavior-preserving refactor to avoid double negatives.
This commit is contained in:
Lőrinc
2026-01-12 00:13:04 +01:00
parent 8be54e3b19
commit 8d531c6210
5 changed files with 16 additions and 18 deletions

View File

@@ -1030,13 +1030,11 @@ public:
ValidationCache m_validation_cache;
/**
* Whether initial block download has ended and IsInitialBlockDownload
* should return false from now on.
* Whether initial block download (IBD) is ongoing.
*
* Mutable because we need to be able to mark IsInitialBlockDownload()
* const, which latches this for caching purposes.
* Once set to false, IsInitialBlockDownload() will keep returning false.
*/
mutable std::atomic<bool> m_cached_finished_ibd{false};
mutable std::atomic_bool m_cached_is_ibd{true};
/**
* Every received block is assigned a unique and increasing identifier, so we