From 8f695379f3149ef51c4797b95dd58627fc2527ed Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer Date: Thu, 9 Oct 2025 10:40:34 +0200 Subject: [PATCH] cmake: Unconditionally set WIN32_EXECUTABLE target property The property only has an effect when building for WIN32. Checking for WIN32 before setting the property is redundant. --- src/qt/CMakeLists.txt | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/qt/CMakeLists.txt b/src/qt/CMakeLists.txt index 3a6ee2d1289..ae557d86e3d 100644 --- a/src/qt/CMakeLists.txt +++ b/src/qt/CMakeLists.txt @@ -255,7 +255,7 @@ endif() add_subdirectory(locale) -add_executable(bitcoin-qt +add_executable(bitcoin-qt WIN32 main.cpp ../init/bitcoin-qt.cpp ) @@ -271,12 +271,9 @@ target_link_libraries(bitcoin-qt import_plugins(bitcoin-qt) install_binary_component(bitcoin-qt HAS_MANPAGE) -if(WIN32) - set_target_properties(bitcoin-qt PROPERTIES WIN32_EXECUTABLE TRUE) -endif() if(ENABLE_IPC) - add_executable(bitcoin-gui + add_executable(bitcoin-gui WIN32 main.cpp ../init/bitcoin-gui.cpp ) @@ -288,9 +285,6 @@ if(ENABLE_IPC) ) import_plugins(bitcoin-gui) install_binary_component(bitcoin-gui INTERNAL) - if(WIN32) - set_target_properties(bitcoin-gui PROPERTIES WIN32_EXECUTABLE TRUE) - endif() endif() if(BUILD_GUI_TESTS)