rpc: print useful help and error message for generate

This commit is contained in:
Jon Atack
2020-07-09 17:13:51 +02:00
parent 8d32d2011d
commit 92d94ffb8d

View File

@@ -236,6 +236,17 @@ static UniValue generatetodescriptor(const JSONRPCRequest& request)
return generateBlocks(chainman, mempool, coinbase_script, num_blocks, max_tries);
}
static UniValue generate(const JSONRPCRequest& request)
{
const std::string help_str{"generate ( nblocks maxtries ) has been replaced by the -generate cli option. Refer to -help for more information."};
if (request.fHelp) {
throw std::runtime_error(help_str);
} else {
throw JSONRPCError(RPC_METHOD_NOT_FOUND, help_str);
}
}
static UniValue generatetoaddress(const JSONRPCRequest& request)
{
RPCHelpMan{"generatetoaddress",
@@ -1198,6 +1209,7 @@ static const CRPCCommand commands[] =
{ "util", "estimatesmartfee", &estimatesmartfee, {"conf_target", "estimate_mode"} },
{ "hidden", "estimaterawfee", &estimaterawfee, {"conf_target", "threshold"} },
{ "hidden", "generate", &generate, {} },
};
// clang-format on