highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-12 06:58:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

tiny refactor for ArgsManager

Browse Source 
This commit contains 2 refactors.

1. mark "const" on ArgsManager::GetHelpMessage and IsArgKnown.
2. remove unused "error" argument from ArgsManager::IsArgKnown.

Firstly, I mark "const" on where it is possible to. It is mentioned
before (e.g. https://github.com/bitcoin/bitcoin/pull/13190#pullrequestreview-118823133).

And about 2nd change, ArgsManager::IsArgKnown was added at commit #4f8704d which was
merged at PR #13112. But from its beggining, "error" argument never be used.
I think it should be refactored.
This commit is contained in:
AtsukiTak
2018-07-21 18:53:54 +09:00
parent 07ce278455
commit 9544a3f3fc
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/util.h
View File

@@ -276,12 +276,12 @@ public:
/**
* Get the help string
*/
std::string GetHelpMessage();
std::string GetHelpMessage() const;
/**
* Check whether we know of this arg
*/
bool IsArgKnown(const std::string& key, std::string& error);
bool IsArgKnown(const std::string& key) const;
};
extern ArgsManager gArgs;