diff --git a/src/bench/index_blockfilter.cpp b/src/bench/index_blockfilter.cpp index 18cd4b6f5a0..7cf501a6a7e 100644 --- a/src/bench/index_blockfilter.cpp +++ b/src/bench/index_blockfilter.cpp @@ -25,6 +25,8 @@ #include #include +using namespace util::hex_literals; + // Very simple block filter index sync benchmark, only using coinbase outputs. static void BlockFilterIndexSync(benchmark::Bench& bench) { diff --git a/src/test/script_standard_tests.cpp b/src/test/script_standard_tests.cpp index 6befd9ba85b..d06118946f7 100644 --- a/src/test/script_standard_tests.cpp +++ b/src/test/script_standard_tests.cpp @@ -16,6 +16,7 @@ #include +using namespace util::hex_literals; BOOST_FIXTURE_TEST_SUITE(script_standard_tests, BasicTestingSetup) diff --git a/src/test/script_tests.cpp b/src/test/script_tests.cpp index a1267802b46..e141624b76e 100644 --- a/src/test/script_tests.cpp +++ b/src/test/script_tests.cpp @@ -1356,10 +1356,16 @@ BOOST_AUTO_TEST_CASE(script_GetScriptAsm) BOOST_CHECK_EQUAL(derSig + "83 " + pubKey, ScriptToAsmStr(CScript() << ToByteVector(ParseHex(derSig + "83")) << vchPubKey)); } +template +CScript ToScript(const T& byte_container) +{ + auto span{MakeUCharSpan(byte_container)}; + return {span.begin(), span.end()}; +} + static CScript ScriptFromHex(const std::string& str) { - std::vector data = ParseHex(str); - return CScript(data.begin(), data.end()); + return ToScript(*Assert(TryParseHex(str))); } BOOST_AUTO_TEST_CASE(script_FindAndDelete) @@ -1393,7 +1399,7 @@ BOOST_AUTO_TEST_CASE(script_FindAndDelete) BOOST_CHECK_EQUAL(FindAndDelete(s, d), 1); BOOST_CHECK(s == expect); - s = ScriptFromHex("0302ff030302ff03"); // PUSH 0x2ff03 PUSH 0x2ff03 + s = ToScript("0302ff030302ff03"_hex); // PUSH 0x02ff03 PUSH 0x02ff03 d = ScriptFromHex("0302ff03"); expect = CScript(); BOOST_CHECK_EQUAL(FindAndDelete(s, d), 2);