From ba901eecfa66a9db9d5b0212faf48057784107a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C5=91rinc?= Date: Mon, 6 Jan 2025 12:31:05 +0100 Subject: [PATCH] scripted-diff: Replace invalid txid in RPC examples with valid one The examples previously used a 63-character txid, which caused RPC errors such as: - error code: -8, error message: txid must be of length 64 This commit replaces the invalid txid with a valid one, taken from https://github.com/bitcoin/bitcoin/blob/df5c643f92d4a6b1ef4dfe4b9c54f902990bb54b/src/validation.cpp#L2582. -BEGIN VERIFY SCRIPT- sed -i \ 's/1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d/d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781/g' \ $(git ls-files src/) -END VERIFY SCRIPT- --- src/wallet/rpc/transactions.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wallet/rpc/transactions.cpp b/src/wallet/rpc/transactions.cpp index 61cf36a6c10..30be375912b 100644 --- a/src/wallet/rpc/transactions.cpp +++ b/src/wallet/rpc/transactions.cpp @@ -743,10 +743,10 @@ RPCHelpMan gettransaction() }) }, RPCExamples{ - HelpExampleCli("gettransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\"") - + HelpExampleCli("gettransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\" true") - + HelpExampleCli("gettransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\" false true") - + HelpExampleRpc("gettransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\"") + HelpExampleCli("gettransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\"") + + HelpExampleCli("gettransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\" true") + + HelpExampleCli("gettransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\" false true") + + HelpExampleRpc("gettransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\"") }, [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue { @@ -818,8 +818,8 @@ RPCHelpMan abandontransaction() }, RPCResult{RPCResult::Type::NONE, "", ""}, RPCExamples{ - HelpExampleCli("abandontransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\"") - + HelpExampleRpc("abandontransaction", "\"1075db55d416d3ca199f55b6084e2115b9345e16c5cf302fc80e9d5fbf5d48d\"") + HelpExampleCli("abandontransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\"") + + HelpExampleRpc("abandontransaction", "\"d4f7fbbf92f4a3014a230b2dc70b8058d02eb36ac06b4a0736d9d60eaa9e8781\"") }, [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue {