From a3fe455a953d32dc6d3f07d7db7e478a52ad3d05 Mon Sep 17 00:00:00 2001 From: rkrux Date: Tue, 26 May 2026 19:07:24 +0530 Subject: [PATCH] wallet: refactor to read -walletrbf only once instead of twice --- src/wallet/wallet.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 77d0a395c93..0fbe8cc0687 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -3104,9 +3104,9 @@ bool CWallet::LoadWalletArgs(std::shared_ptr wallet, const WalletContex wallet->m_confirm_target = args.GetIntArg("-txconfirmtarget", DEFAULT_TX_CONFIRM_TARGET); wallet->m_spend_zero_conf_change = args.GetBoolArg("-spendzeroconfchange", DEFAULT_SPEND_ZEROCONF_CHANGE); wallet->m_signal_rbf = DEFAULT_WALLET_RBF; - if (args.IsArgSet("-walletrbf")) { + if (auto value{args.GetBoolArg("-walletrbf")}) { warnings.push_back(_("-walletrbf is deprecated and will be fully removed in the next release.")); - wallet->m_signal_rbf = args.GetBoolArg("-walletrbf").value(); + wallet->m_signal_rbf = *value; } wallet->m_keypool_size = std::max(args.GetIntArg("-keypool", DEFAULT_KEYPOOL_SIZE), int64_t{1});