diff --git a/ci/test/03_test_script.sh b/ci/test/03_test_script.sh index 6914a5af18a..b3ab1729853 100755 --- a/ci/test/03_test_script.sh +++ b/ci/test/03_test_script.sh @@ -229,7 +229,7 @@ fi if [[ "${RUN_IWYU}" == true ]]; then # TODO: Consider enforcing IWYU across the entire codebase. - FILES_WITH_ENFORCED_IWYU="/src/(((crypto|index|kernel|primitives|univalue/(lib|test)|util|zmq)/.*|common/license_info|node/blockstorage|node/utxo_snapshot|clientversion|core_io|signet)\\.cpp)" + FILES_WITH_ENFORCED_IWYU="/src/(((crypto|index|kernel|primitives|univalue/(lib|test)|util|zmq)/.*|bench/(block_assemble|connectblock)|common/license_info|node/(blockstorage|interfaces|miner|mining_args|utxo_snapshot)|rpc/mining|clientversion|core_io|signet|init)\\.cpp)" jq --arg patterns "$FILES_WITH_ENFORCED_IWYU" 'map(select(.file | test($patterns)))' "${BASE_BUILD_DIR}/compile_commands.json" > "${BASE_BUILD_DIR}/compile_commands_iwyu_errors.json" jq --arg patterns "$FILES_WITH_ENFORCED_IWYU" 'map(select(.file | test($patterns) | not))' "${BASE_BUILD_DIR}/compile_commands.json" > "${BASE_BUILD_DIR}/compile_commands_iwyu_warnings.json" diff --git a/doc/release-notes-33966.md b/doc/release-notes-33966.md new file mode 100644 index 00000000000..7251a13d52d --- /dev/null +++ b/doc/release-notes-33966.md @@ -0,0 +1,9 @@ +Mining +------ + +- The IPC mining interface now rejects out-of-range block template options + instead of silently clamping them, such as oversized reserved block weight or + coinbase sigops limits. (#33966) + +- The `-blockmaxweight` startup option is now rejected when it is lower than + `-blockreservedweight`, instead of being silently clamped. (#33966) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index f250484723f..524c28165cc 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -232,6 +232,7 @@ add_library(bitcoin_node STATIC EXCLUDE_FROM_ALL node/mempool_persist.cpp node/mempool_persist_args.cpp node/miner.cpp + node/mining_args.cpp node/mini_miner.cpp node/minisketchwrapper.cpp node/peerman_args.cpp diff --git a/src/bench/block_assemble.cpp b/src/bench/block_assemble.cpp index 297465be80f..be03917417e 100644 --- a/src/bench/block_assemble.cpp +++ b/src/bench/block_assemble.cpp @@ -4,7 +4,7 @@ #include #include -#include +#include #include #include #include