diff --git a/cmake/bitcoin-build-config.h.in b/cmake/bitcoin-build-config.h.in index 4783209ef77..bf3ddcd7ff6 100644 --- a/cmake/bitcoin-build-config.h.in +++ b/cmake/bitcoin-build-config.h.in @@ -29,18 +29,9 @@ /* Copyright year */ #define COPYRIGHT_YEAR @COPYRIGHT_YEAR@ -/* Define this symbol to build code that uses ARMv8 SHA-NI intrinsics */ -#cmakedefine ENABLE_ARM_SHANI 1 - -/* Define this symbol to build code that uses AVX2 intrinsics */ -#cmakedefine ENABLE_AVX2 1 - /* Define if external signer support is enabled */ #cmakedefine ENABLE_EXTERNAL_SIGNER 1 -/* Define this symbol to build code that uses SSE4.1 intrinsics */ -#cmakedefine ENABLE_SSE41 1 - /* Define to 1 to enable tracepoints for Userspace, Statically Defined Tracing */ #cmakedefine ENABLE_TRACING 1 @@ -48,9 +39,6 @@ /* Define to 1 to enable wallet functions. */ #cmakedefine ENABLE_WALLET 1 -/* Define this symbol to build code that uses x86 SHA-NI intrinsics */ -#cmakedefine ENABLE_X86_SHANI 1 - /* Define to 1 if you have the declaration of `fork', and to 0 if you don't. */ #cmakedefine01 HAVE_DECL_FORK diff --git a/cmake/introspection.cmake b/cmake/introspection.cmake index 0efcf7c63c7..fb94a120553 100644 --- a/cmake/introspection.cmake +++ b/cmake/introspection.cmake @@ -170,7 +170,6 @@ if(NOT MSVC) " HAVE_SSE41 CXXFLAGS ${SSE41_CXXFLAGS} ) - set(ENABLE_SSE41 ${HAVE_SSE41}) # Check for AVX2 intrinsics. set(AVX2_CXXFLAGS -mavx -mavx2) @@ -185,7 +184,6 @@ if(NOT MSVC) " HAVE_AVX2 CXXFLAGS ${AVX2_CXXFLAGS} ) - set(ENABLE_AVX2 ${HAVE_AVX2}) # Check for x86 SHA-NI intrinsics. set(X86_SHANI_CXXFLAGS -msse4 -msha) @@ -202,7 +200,6 @@ if(NOT MSVC) " HAVE_X86_SHANI CXXFLAGS ${X86_SHANI_CXXFLAGS} ) - set(ENABLE_X86_SHANI ${HAVE_X86_SHANI}) # Check for ARMv8 SHA-NI intrinsics. set(ARM_SHANI_CXXFLAGS -march=armv8-a+crypto) @@ -220,5 +217,4 @@ if(NOT MSVC) " HAVE_ARM_SHANI CXXFLAGS ${ARM_SHANI_CXXFLAGS} ) - set(ENABLE_ARM_SHANI ${HAVE_ARM_SHANI}) endif() diff --git a/src/crypto/CMakeLists.txt b/src/crypto/CMakeLists.txt index 1109806a776..92653ade5a7 100644 --- a/src/crypto/CMakeLists.txt +++ b/src/crypto/CMakeLists.txt @@ -47,7 +47,7 @@ if(HAVE_SSE41 AND HAVE_X86_SHANI) target_compile_definitions(bitcoin_crypto PRIVATE ENABLE_SSE41 ENABLE_X86_SHANI) target_sources(bitcoin_crypto PRIVATE sha256_x86_shani.cpp) set_property(SOURCE sha256_x86_shani.cpp PROPERTY - COMPILE_OPTIONS ${X86_SHANI_CXXFLAGS} + COMPILE_OPTIONS ${SSE41_CXXFLAGS} ${X86_SHANI_CXXFLAGS} ) endif() diff --git a/src/crypto/sha256.cpp b/src/crypto/sha256.cpp index 09c5d3123e8..902ebf18a6f 100644 --- a/src/crypto/sha256.cpp +++ b/src/crypto/sha256.cpp @@ -2,8 +2,6 @@ // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -#include // IWYU pragma: keep - #include #include diff --git a/test/lint/test_runner/src/main.rs b/test/lint/test_runner/src/main.rs index 073e2dd44cd..c2f82573352 100644 --- a/test/lint/test_runner/src/main.rs +++ b/test/lint/test_runner/src/main.rs @@ -614,15 +614,7 @@ fn lint_includes_build_config() -> LintResult { "*.cpp", "*.h", ]) - .args(get_pathspecs_default_excludes()) - .args([ - // These are exceptions which don't use bitcoin-build-config.h, rather CMakeLists.txt adds - // these cppflags manually. - ":(exclude)src/crypto/sha256_arm_shani.cpp", - ":(exclude)src/crypto/sha256_avx2.cpp", - ":(exclude)src/crypto/sha256_sse41.cpp", - ":(exclude)src/crypto/sha256_x86_shani.cpp", - ]), + .args(get_pathspecs_default_excludes()), ) .expect("grep failed"); git()