From a7e980af31b92f5a21be6b91bed353e65c5cf770 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Tue, 21 Jul 2026 20:25:21 +0100 Subject: [PATCH] build: Quote host paths in NSIS installer template The `File` instructions embed the build and source directories unquoted, so `makensis` fails for the `deploy` target when either path contains spaces. --- share/setup.nsi.in | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/share/setup.nsi.in b/share/setup.nsi.in index d807b718b20..33baa477841 100644 --- a/share/setup.nsi.in +++ b/share/setup.nsi.in @@ -72,19 +72,19 @@ ShowUninstDetails show Section -Main SEC0000 SetOutPath $INSTDIR SetOverwrite on - File @BIN_DIR@/@BITCOIN_GUI_NAME@@EXEEXT@ - File @BIN_DIR@/@BITCOIN_WRAPPER_NAME@@EXEEXT@ - File /oname=COPYING.txt @abs_top_srcdir@/COPYING - File /oname=readme.txt @abs_top_srcdir@/doc/README_windows.txt - File @abs_top_srcdir@/share/examples/bitcoin.conf + File "@BIN_DIR@/@BITCOIN_GUI_NAME@@EXEEXT@" + File "@BIN_DIR@/@BITCOIN_WRAPPER_NAME@@EXEEXT@" + File /oname=COPYING.txt "@abs_top_srcdir@/COPYING" + File /oname=readme.txt "@abs_top_srcdir@/doc/README_windows.txt" + File "@abs_top_srcdir@/share/examples/bitcoin.conf" SetOutPath $INSTDIR\share\rpcauth - File @abs_top_srcdir@/share/rpcauth/*.* + File "@abs_top_srcdir@/share/rpcauth/*.*" SetOutPath $INSTDIR\daemon - File @BIN_DIR@/@BITCOIN_DAEMON_NAME@@EXEEXT@ - File @BIN_DIR@/@BITCOIN_CLI_NAME@@EXEEXT@ - File @BIN_DIR@/@BITCOIN_TX_NAME@@EXEEXT@ - File @BIN_DIR@/@BITCOIN_WALLET_TOOL_NAME@@EXEEXT@ - File @LIBEXEC_DIR@/@BITCOIN_TEST_NAME@@EXEEXT@ + File "@BIN_DIR@/@BITCOIN_DAEMON_NAME@@EXEEXT@" + File "@BIN_DIR@/@BITCOIN_CLI_NAME@@EXEEXT@" + File "@BIN_DIR@/@BITCOIN_TX_NAME@@EXEEXT@" + File "@BIN_DIR@/@BITCOIN_WALLET_TOOL_NAME@@EXEEXT@" + File "@LIBEXEC_DIR@/@BITCOIN_TEST_NAME@@EXEEXT@" SetOutPath $INSTDIR WriteRegStr HKCU "${REGKEY}\Components" Main 1 SectionEnd