From a9d42b9aa579f54922ffd17fdeb61e704539b92c Mon Sep 17 00:00:00 2001
From: Greg Sanders <gsanders87@gmail.com>
Date: Tue, 26 Mar 2024 08:41:06 -0400
Subject: [PATCH] CompareFeerateDiagram: short-circuit comparison when detected
 as incomparable

---
 src/util/feefrac.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/util/feefrac.cpp b/src/util/feefrac.cpp
index 215498f2874..68fb8369360 100644
--- a/src/util/feefrac.cpp
+++ b/src/util/feefrac.cpp
@@ -76,10 +76,12 @@ std::partial_ordering CompareFeerateDiagram(Span<const FeeFrac> dia0, Span<const
         if (std::is_gt(cmp)) better_somewhere[unproc_side] = true;
         if (std::is_lt(cmp)) better_somewhere[!unproc_side] = true;
         ++next_index[unproc_side];
+
+        // If both diagrams are better somewhere, they are incomparable.
+        if (better_somewhere[0] && better_somewhere[1]) return std::partial_ordering::unordered;
+
     } while(true);
 
-    // If both diagrams are better somewhere, they are incomparable.
-    if (better_somewhere[0] && better_somewhere[1]) return std::partial_ordering::unordered;
     // Otherwise compare the better_somewhere values.
     return better_somewhere[0] <=> better_somewhere[1];
 }