From 3210f224dbeaf0f9de09d4e83c3e6666128a6717 Mon Sep 17 00:00:00 2001
From: fanquake <fanquake@gmail.com>
Date: Thu, 29 Jun 2023 14:41:33 +0100
Subject: [PATCH] refactor: remove in-code warning suppression

Should no-longer be needed post #27872. If it is, then
suppress-external-warnings should be fixed.
---
 src/common/run_command.cpp | 9 ---------
 src/test/system_tests.cpp  | 9 ---------
 src/wallet/bdb.h           | 7 -------
 3 files changed, 25 deletions(-)

diff --git a/src/common/run_command.cpp b/src/common/run_command.cpp
index 6ad9f75b5d9..8bd5febd538 100644
--- a/src/common/run_command.cpp
+++ b/src/common/run_command.cpp
@@ -12,16 +12,7 @@
 #include <univalue.h>
 
 #ifdef ENABLE_EXTERNAL_SIGNER
-#if defined(__GNUC__)
-// Boost 1.78 requires the following workaround.
-// See: https://github.com/boostorg/process/issues/235
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wnarrowing"
-#endif
 #include <boost/process.hpp>
-#if defined(__GNUC__)
-#pragma GCC diagnostic pop
-#endif
 #endif // ENABLE_EXTERNAL_SIGNER
 
 UniValue RunCommandParseJSON(const std::string& str_command, const std::string& str_std_in)
diff --git a/src/test/system_tests.cpp b/src/test/system_tests.cpp
index 7ce350b84bc..740f4615484 100644
--- a/src/test/system_tests.cpp
+++ b/src/test/system_tests.cpp
@@ -7,16 +7,7 @@
 #include <univalue.h>
 
 #ifdef ENABLE_EXTERNAL_SIGNER
-#if defined(__GNUC__)
-// Boost 1.78 requires the following workaround.
-// See: https://github.com/boostorg/process/issues/235
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wnarrowing"
-#endif
 #include <boost/process.hpp>
-#if defined(__GNUC__)
-#pragma GCC diagnostic pop
-#endif
 #endif // ENABLE_EXTERNAL_SIGNER
 
 #include <boost/test/unit_test.hpp>
diff --git a/src/wallet/bdb.h b/src/wallet/bdb.h
index 8cc03692d6a..1073d32e0f2 100644
--- a/src/wallet/bdb.h
+++ b/src/wallet/bdb.h
@@ -21,14 +21,7 @@
 #include <unordered_map>
 #include <vector>
 
-#if defined(__GNUC__) && !defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wsuggest-override"
-#endif
 #include <db_cxx.h>
-#if defined(__GNUC__) && !defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
 
 struct bilingual_str;