diff --git a/doc/release-notes-29060.md b/doc/release-notes-29060.md new file mode 100644 index 00000000000..bb11dc91365 --- /dev/null +++ b/doc/release-notes-29060.md @@ -0,0 +1,10 @@ +- Logging and RPC + + - Bitcoin Core now reports a debug message explaining why transaction inputs are non-standard. + + - This information is now returned in the responses of the transaction-sending RPCs `submitpackage`, + `sendrawtransaction`, and `testmempoolaccept`, and is also logged to `debug.log` (if `mempoolrej` ++ debug category is enabled) when such transactions are received over the P2P network. + + - This does not change the existing error code `bad-txns-nonstandard-inputs`, but instead adds additional debug information to it. + diff --git a/src/bench/ccoins_caching.cpp b/src/bench/ccoins_caching.cpp index 2b7315f4c16..82735b3286e 100644 --- a/src/bench/ccoins_caching.cpp +++ b/src/bench/ccoins_caching.cpp @@ -49,8 +49,7 @@ static void CCoinsCaching(benchmark::Bench& bench) // Benchmark. const CTransaction tx_1(t1); bench.run([&] { - bool success{AreInputsStandard(tx_1, coins)}; - assert(success); + assert(ValidateInputsStandardness(tx_1, coins).IsValid()); }); } diff --git a/src/policy/policy.cpp b/src/policy/policy.cpp index 46ec238c3b1..83ceb63cbcd 100644 --- a/src/policy/policy.cpp +++ b/src/policy/policy.cpp @@ -18,6 +18,7 @@ #include