diff --git a/src/init.cpp b/src/init.cpp index 3cfd301fbab..bf8393e45a2 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1902,6 +1902,10 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) const uint16_t default_bind_port_onion = default_bind_port + 1; + // If the user did not specify -bind= or -whitebind= then we bind + // on any address - 0.0.0.0 (IPv4) and :: (IPv6). + connOptions.bind_on_any = args.GetArgs("-bind").empty() && args.GetArgs("-whitebind").empty(); + const auto BadPortWarning = [](const char* prefix, uint16_t port) { return strprintf(_("%s request to listen on port %u. This port is considered \"bad\" and " "thus it is unlikely that any peer will connect to it. See " @@ -1916,6 +1920,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) if (index == std::string::npos) { bind_addr = Lookup(bind_arg, default_bind_port, /*fAllowLookup=*/false); if (bind_addr.has_value()) { + connOptions.bind_on_any |= bind_addr.value().IsBindAny(); connOptions.vBinds.push_back(bind_addr.value()); if (IsBadPort(bind_addr.value().GetPort())) { InitWarning(BadPortWarning("-bind", bind_addr.value().GetPort())); @@ -1928,6 +1933,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) const std::string truncated_bind_arg = bind_arg.substr(0, index); bind_addr = Lookup(truncated_bind_arg, default_bind_port_onion, false); if (bind_addr.has_value()) { + connOptions.bind_on_any |= bind_addr.value().IsBindAny(); connOptions.onion_binds.push_back(bind_addr.value()); continue; } @@ -1943,10 +1949,6 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) connOptions.vWhiteBinds.push_back(whitebind); } - // If the user did not specify -bind= or -whitebind= then we bind - // on any address - 0.0.0.0 (IPv4) and :: (IPv6). - connOptions.bind_on_any = args.GetArgs("-bind").empty() && args.GetArgs("-whitebind").empty(); - // Emit a warning if a bad port is given to -port= but only if -bind and -whitebind are not // given, because if they are, then -port= is ignored. if (connOptions.bind_on_any && args.IsArgSet("-port")) { @@ -1963,7 +1965,6 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) onion_service_target = connOptions.vBinds.front(); } else { onion_service_target = DefaultOnionServiceTarget(default_bind_port_onion); - connOptions.onion_binds.push_back(onion_service_target); } if (args.GetBoolArg("-listenonion", DEFAULT_LISTEN_ONION)) { diff --git a/src/net.cpp b/src/net.cpp index 735985a8414..55a3fa485a5 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -146,8 +146,10 @@ uint16_t GetListenPort() // If -bind= is provided with ":port" part, use that (first one if multiple are provided). for (const std::string& bind_arg : gArgs.GetArgs("-bind")) { constexpr uint16_t dummy_port = 0; + // maybe bind_arg has "=onion" + const std::string truncated_bind_arg = bind_arg.substr(0, bind_arg.rfind('=')); - const std::optional bind_addr{Lookup(bind_arg, dummy_port, /*fAllowLookup=*/false)}; + const std::optional bind_addr{Lookup(truncated_bind_arg, dummy_port, /*fAllowLookup=*/false)}; if (bind_addr.has_value() && bind_addr->GetPort() != dummy_port) return bind_addr->GetPort(); } @@ -3273,7 +3275,7 @@ bool CConnman::InitBinds(const Options& options) return false; } } - if (options.bind_on_any) { + if (options.bind_on_any && options.vBinds.empty() && options.onion_binds.empty()) { // Don't consider errors to bind on IPv6 "::" fatal because the host OS // may not have IPv6 support and the user did not explicitly ask us to // bind on that. @@ -3286,6 +3288,14 @@ bool CConnman::InitBinds(const Options& options) if (!Bind(ipv4_any, BF_REPORT_ERROR, NetPermissionFlags::None)) { return false; } + + struct in_addr onion_service_target; + onion_service_target.s_addr = htonl(INADDR_LOOPBACK); + const uint16_t onion_port = GetListenPort() + 1; + const CService onion_addr = {onion_service_target, onion_port}; // 127.0.0.1 + if (!Bind(onion_addr, BF_REPORT_ERROR | BF_DONT_ADVERTISE, NetPermissionFlags::None)) { + return false; + } } return true; }