From c43aa623435a277a692dbde784e8a7146f5573e9 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Sat, 30 Oct 2021 19:33:09 +0300 Subject: [PATCH] Avoid excessive lock contention in CCheckQueue::Add --- src/checkqueue.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/checkqueue.h b/src/checkqueue.h index 7c20e2013c3..d926326a959 100644 --- a/src/checkqueue.h +++ b/src/checkqueue.h @@ -167,12 +167,15 @@ public: //! Add a batch of checks to the queue void Add(std::vector& vChecks) { - LOCK(m_mutex); - for (T& check : vChecks) { - queue.push_back(T()); - check.swap(queue.back()); + { + LOCK(m_mutex); + for (T& check : vChecks) { + queue.emplace_back(); + check.swap(queue.back()); + } + nTodo += vChecks.size(); } - nTodo += vChecks.size(); + if (vChecks.size() == 1) m_worker_cv.notify_one(); else if (vChecks.size() > 1)