diff --git a/ci/lint/04_install.sh b/ci/lint/04_install.sh index 9ef1f37c73..c38a173dc4 100755 --- a/ci/lint/04_install.sh +++ b/ci/lint/04_install.sh @@ -12,10 +12,11 @@ pushd "/" ${CI_RETRY_EXE} apt-get update # Lint dependencies: +# - cargo (used to run the lint tests) # - curl/xz-utils (to install shellcheck) # - git (used in many lint scripts) # - gpg (used by verify-commits) -${CI_RETRY_EXE} apt-get install -y curl xz-utils git gpg +${CI_RETRY_EXE} apt-get install -y cargo curl xz-utils git gpg PYTHON_PATH="/python_build" if [ ! -d "${PYTHON_PATH}/bin" ]; then @@ -35,17 +36,6 @@ export PATH="${PYTHON_PATH}/bin:${PATH}" command -v python3 python3 --version -export LINT_RUNNER_PATH="/lint_test_runner" -if [ ! -d "${LINT_RUNNER_PATH}" ]; then - ${CI_RETRY_EXE} apt-get install -y cargo - ( - cd "/test/lint/test_runner" || exit 1 - cargo build - mkdir -p "${LINT_RUNNER_PATH}" - mv target/debug/test_runner "${LINT_RUNNER_PATH}" - ) -fi - ${CI_RETRY_EXE} pip3 install \ codespell==2.2.6 \ lief==0.13.2 \ diff --git a/ci/lint/06_script.sh b/ci/lint/06_script.sh index 7e27197024..6d637c2a43 100755 --- a/ci/lint/06_script.sh +++ b/ci/lint/06_script.sh @@ -16,7 +16,7 @@ if [ -n "$CIRRUS_PR" ]; then fi fi -RUST_BACKTRACE=1 "${LINT_RUNNER_PATH}/test_runner" +RUST_BACKTRACE=1 cargo run --manifest-path "./test/lint/test_runner/Cargo.toml" if [ "$CIRRUS_REPO_FULL_NAME" = "bitcoin/bitcoin" ] && [ "$CIRRUS_PR" = "" ] ; then # Sanity check only the last few commits to get notified of missing sigs, diff --git a/ci/lint/container-entrypoint.sh b/ci/lint/container-entrypoint.sh index c8519a3912..84e60be291 100755 --- a/ci/lint/container-entrypoint.sh +++ b/ci/lint/container-entrypoint.sh @@ -11,7 +11,6 @@ export LC_ALL=C git config --global --add safe.directory /bitcoin export PATH="/python_build/bin:${PATH}" -export LINT_RUNNER_PATH="/lint_test_runner" if [ -z "$1" ]; then bash -ic "./ci/lint/06_script.sh" diff --git a/ci/lint_imagefile b/ci/lint_imagefile index c05f2108f7..9da3747e08 100644 --- a/ci/lint_imagefile +++ b/ci/lint_imagefile @@ -4,7 +4,7 @@ # See test/lint/README.md for usage. -FROM mirror.gcr.io/debian:bookworm +FROM mirror.gcr.io/ubuntu:24.04 ENV DEBIAN_FRONTEND=noninteractive ENV LC_ALL=C.UTF-8 @@ -13,7 +13,6 @@ COPY ./ci/retry/retry /ci_retry COPY ./.python-version /.python-version COPY ./ci/lint/container-entrypoint.sh /entrypoint.sh COPY ./ci/lint/04_install.sh /install.sh -COPY ./test/lint/test_runner /test/lint/test_runner RUN /install.sh && \ echo 'alias lint="./ci/lint/06_script.sh"' >> ~/.bashrc && \ diff --git a/ci/lint_run.sh b/ci/lint_run.sh index 319cdc214a..6327c3c456 100755 --- a/ci/lint_run.sh +++ b/ci/lint_run.sh @@ -9,5 +9,4 @@ set -o errexit -o pipefail -o xtrace # Only used in .cirrus.yml. Refer to test/lint/README.md on how to run locally. export PATH="/python_build/bin:${PATH}" -export LINT_RUNNER_PATH="/lint_test_runner" ./ci/lint/06_script.sh diff --git a/ci/test/00_setup_env_arm.sh b/ci/test/00_setup_env_arm.sh index dfeb72216c..45dabb8f38 100755 --- a/ci/test/00_setup_env_arm.sh +++ b/ci/test/00_setup_env_arm.sh @@ -10,7 +10,7 @@ export HOST=arm-linux-gnueabihf export DPKG_ADD_ARCH="armhf" export PACKAGES="python3-zmq g++-arm-linux-gnueabihf busybox libc6:armhf libstdc++6:armhf libfontconfig1:armhf libxcb1:armhf" export CONTAINER_NAME=ci_arm_linux -export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:noble" # Check that https://packages.ubuntu.com/noble/g++-arm-linux-gnueabihf (version 13.3, similar to guix) can cross-compile +export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" # Check that https://packages.ubuntu.com/noble/g++-arm-linux-gnueabihf (version 13.x, similar to guix) can cross-compile export CI_IMAGE_PLATFORM="linux/arm64" export USE_BUSY_BOX=true export RUN_UNIT_TESTS=true diff --git a/ci/test/00_setup_env_win64.sh b/ci/test/00_setup_env_win64.sh index ba67af264f..d1c5e5a7b2 100755 --- a/ci/test/00_setup_env_win64.sh +++ b/ci/test/00_setup_env_win64.sh @@ -7,7 +7,7 @@ export LC_ALL=C.UTF-8 export CONTAINER_NAME=ci_win64 -export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:noble" # Check that g++-mingw-w64-x86-64-posix (version 13.2, similar to guix) can cross-compile +export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" # Check that https://packages.ubuntu.com/noble/g++-mingw-w64-x86-64-posix (version 13.x, similar to guix) can cross-compile export CI_IMAGE_PLATFORM="linux/amd64" export HOST=x86_64-w64-mingw32 export PACKAGES="g++-mingw-w64-x86-64-posix nsis"