From d6c37b28a7820fd48ec61e959becd9269d144628 Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Mon, 28 Jul 2025 17:16:20 -0400 Subject: [PATCH] qa: remove unnecessary tx removal from compact block The error being checked here is BLOCK_MUTATED, as returned by IsBlockMutated() in FillBlock(). Dropping the fourth transaction from the block is unnecessary and would make testing of other block validation failures in following commits more verbose. --- test/functional/p2p_compactblocks.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test/functional/p2p_compactblocks.py b/test/functional/p2p_compactblocks.py index 72890233037..7671a6fdd84 100755 --- a/test/functional/p2p_compactblocks.py +++ b/test/functional/p2p_compactblocks.py @@ -709,7 +709,6 @@ class CompactBlocksTest(BitcoinTestFramework): utxo = self.utxos[0] block = self.build_block_with_transactions(node, utxo, 5) - del block.vtx[3] block.hashMerkleRoot = block.calc_merkle_root() # Drop the coinbase witness but include the witness commitment. add_witness_commitment(block)