From d88c0d8440cf640ef4f2c7a40b8b8b31bfd38f23 Mon Sep 17 00:00:00 2001
From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
Date: Tue, 18 Jan 2022 19:02:05 +0200
Subject: [PATCH] refactor: Get rid of `BanMan::BannedSetIsDirty()`

---
 src/banman.cpp | 8 +-------
 src/banman.h   | 1 -
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/banman.cpp b/src/banman.cpp
index 2a6e0e010fe..50dc0750e1f 100644
--- a/src/banman.cpp
+++ b/src/banman.cpp
@@ -53,7 +53,7 @@ void BanMan::DumpBanlist()
     {
         LOCK(m_cs_banned);
         SweepBanned();
-        if (!BannedSetIsDirty()) return;
+        if (!m_is_dirty) return;
         banmap = m_banned;
         SetBannedSetDirty(false);
     }
@@ -203,12 +203,6 @@ void BanMan::SweepBanned()
     }
 }
 
-bool BanMan::BannedSetIsDirty()
-{
-    LOCK(m_cs_banned);
-    return m_is_dirty;
-}
-
 void BanMan::SetBannedSetDirty(bool dirty)
 {
     LOCK(m_cs_banned); //reuse m_banned lock for the m_is_dirty flag
diff --git a/src/banman.h b/src/banman.h
index 77b043f081b..7f3c74733ed 100644
--- a/src/banman.h
+++ b/src/banman.h
@@ -81,7 +81,6 @@ public:
 
 private:
     void LoadBanlist() EXCLUSIVE_LOCKS_REQUIRED(!m_cs_banned);
-    bool BannedSetIsDirty();
     //!set the "dirty" flag for the banlist
     void SetBannedSetDirty(bool dirty = true);
     //!clean unused entries (if bantime has expired)