From 03b3166aac5acbf3eec95681c0ab98c4f94ab177 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Tue, 18 Feb 2025 16:02:56 +0000 Subject: [PATCH 1/2] cmake: Exclude generated sources from translation --- src/qt/CMakeLists.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qt/CMakeLists.txt b/src/qt/CMakeLists.txt index 7fbbd81c415..22576fc7168 100644 --- a/src/qt/CMakeLists.txt +++ b/src/qt/CMakeLists.txt @@ -288,7 +288,13 @@ function(get_translatable_sources var) get_target_property(target_source_dir ${target} SOURCE_DIR) cmake_path(APPEND target_source_dir ${source} OUTPUT_VARIABLE source) endif() - list(APPEND result ${source}) + get_property(is_generated + SOURCE ${source} TARGET_DIRECTORY ${target} + PROPERTY GENERATED + ) + if(NOT is_generated) + list(APPEND result ${source}) + endif() endforeach() endif() endforeach() From ff4ddd3d2e3b08156fd0a0aeb954fde0a5f4cb03 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Tue, 18 Feb 2025 16:05:08 +0000 Subject: [PATCH 2/2] Revert "cmake: Ensure generated sources are up to date for `translate` target" This reverts commit 864386a7444fb5cf16613956ce8bf335f51b67d5. --- src/qt/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qt/CMakeLists.txt b/src/qt/CMakeLists.txt index 22576fc7168..797b49c624d 100644 --- a/src/qt/CMakeLists.txt +++ b/src/qt/CMakeLists.txt @@ -325,7 +325,6 @@ else() COMMAND Qt5::lconvert -drop-translations -o ${CMAKE_CURRENT_SOURCE_DIR}/locale/bitcoin_en.xlf -i ${CMAKE_CURRENT_SOURCE_DIR}/locale/bitcoin_en.ts COMMAND ${SED_EXECUTABLE} -i.old -e "s|source-language=\"en\" target-language=\"en\"|source-language=\"en\"|" -e "/<\\/target>/d" ${CMAKE_CURRENT_SOURCE_DIR}/locale/bitcoin_en.xlf COMMAND ${CMAKE_COMMAND} -E rm ${CMAKE_CURRENT_SOURCE_DIR}/locale/bitcoin_en.xlf.old - DEPENDS ${translatable_sources} WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src VERBATIM )