From e755614be586999206fe73b21adfa8b5f8dd0360 Mon Sep 17 00:00:00 2001 From: Fabian Jahr Date: Thu, 16 Oct 2025 00:48:50 +0200 Subject: [PATCH] sign: Remove duplicate sigversion check Also improves documentation in the SignMuSig2 function. --- src/script/sign.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/script/sign.cpp b/src/script/sign.cpp index 8103e318c51..7f9a2214bc9 100644 --- a/src/script/sign.cpp +++ b/src/script/sign.cpp @@ -87,8 +87,6 @@ std::optional MutableTransactionSignatureCreator::ComputeSchnorrSignatu bool MutableTransactionSignatureCreator::CreateSchnorrSig(const SigningProvider& provider, std::vector& sig, const XOnlyPubKey& pubkey, const uint256* leaf_hash, const uint256* merkle_root, SigVersion sigversion) const { - assert(sigversion == SigVersion::TAPROOT || sigversion == SigVersion::TAPSCRIPT); - CKey key; if (!provider.GetKeyByXOnly(pubkey, key)) return false; @@ -342,7 +340,7 @@ static bool SignMuSig2(const BaseSignatureCreator& creator, SignatureData& sigda sigdata.musig2_partial_sigs[pub_key_leaf_hash].emplace(part_pk, partial_sig); } } - // If there are any partial signatures, exit early + // If there are any partial signatures, continue with next aggregate pubkey auto partial_sigs_it = sigdata.musig2_partial_sigs.find(pub_key_leaf_hash); if (partial_sigs_it != sigdata.musig2_partial_sigs.end() && !partial_sigs_it->second.empty()) { continue;