From fadb4f63cb0f0b544bc95e48cb42c7636c1dec15 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Mon, 17 Nov 2025 12:23:34 +0100 Subject: [PATCH] test: Remove tests violating hardened std::span --- src/test/kernel/test_kernel.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/kernel/test_kernel.cpp b/src/test/kernel/test_kernel.cpp index 75c9e466ada..474e0d4a479 100644 --- a/src/test/kernel/test_kernel.cpp +++ b/src/test/kernel/test_kernel.cpp @@ -398,7 +398,6 @@ BOOST_AUTO_TEST_CASE(btck_transaction_tests) BOOST_CHECK_THROW(Transaction{invalid_data}, std::runtime_error); auto empty_data = hex_string_to_byte_vec(""); BOOST_CHECK_THROW(Transaction{empty_data}, std::runtime_error); - BOOST_CHECK_THROW(Transaction{std::span(static_cast(nullptr), 2)}, std::runtime_error); BOOST_CHECK_EQUAL(tx.CountOutputs(), 2); BOOST_CHECK_EQUAL(tx.CountInputs(), 1); @@ -475,7 +474,9 @@ BOOST_AUTO_TEST_CASE(btck_script_pubkey) ScriptPubkey script2{script_data_2}; CheckHandle(script, script2); - BOOST_CHECK_THROW(ScriptPubkey{std::span(static_cast(nullptr), 2)}, std::runtime_error); + std::span empty_data{}; + ScriptPubkey empty_script{empty_data}; + CheckHandle(script, empty_script); } BOOST_AUTO_TEST_CASE(btck_transaction_output) @@ -592,7 +593,6 @@ BOOST_AUTO_TEST_CASE(btck_block) BOOST_CHECK_THROW(Block{invalid_data}, std::runtime_error); auto empty_data = hex_string_to_byte_vec(""); BOOST_CHECK_THROW(Block{empty_data}, std::runtime_error); - BOOST_CHECK_THROW(Block{std::span(static_cast(nullptr), 2)}, std::runtime_error); } Context create_context(std::shared_ptr notifications, ChainType chain_type, std::shared_ptr validation_interface = nullptr)