From ee4406c04af0d851e649f52fc799de37c9a71c04 Mon Sep 17 00:00:00 2001 From: fanquake Date: Fri, 2 May 2025 11:23:30 +0100 Subject: [PATCH] doc: update URLs Some are now redirecting, some are outdated, i.e qt5. --- CONTRIBUTING.md | 8 ++++---- doc/build-windows-msvc.md | 2 +- doc/files.md | 2 +- doc/tracing.md | 2 +- doc/translation_process.md | 6 +++--- doc/zmq.md | 2 +- src/netaddress.cpp | 2 +- src/rpc/request.cpp | 6 +++--- src/test/data/tx_valid.json | 2 +- src/validation.cpp | 2 +- 10 files changed, 17 insertions(+), 17 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 25637b40aa9..b0ba03a3364 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -80,7 +80,7 @@ facilitates social contribution, easy testing and peer review. To contribute a patch, the workflow is as follows: - 1. Fork repository ([only for the first time](https://docs.github.com/en/get-started/quickstart/fork-a-repo)) + 1. Fork repository ([only for the first time](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo)) 1. Create topic branch 1. Commit patches @@ -121,7 +121,7 @@ Commit messages should be verbose by default consisting of a short subject line paragraph(s), unless the title alone is self-explanatory (like "Correct typo in init.cpp") in which case a single title line is sufficient. Commit messages should be helpful to people reading your code in the future, so explain the reasoning for -your decisions. Further explanation [here](https://chris.beams.io/posts/git-commit/). +your decisions. Further explanation [here](https://cbea.ms/git-commit/). If a particular commit references another issue, please add the reference. For example: `refs #1234` or `fixes #4321`. Using the `fixes` or `closes` keywords @@ -182,7 +182,7 @@ for more information on helping with translations. ### Work in Progress Changes and Requests for Comments If a pull request is not to be considered for merging (yet), please -prefix the title with [WIP] or use [Tasks Lists](https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#task-lists) +prefix the title with [WIP] or use [Tasks Lists](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#task-lists) in the body of the pull request to indicate tasks are pending. ### Address Feedback @@ -401,7 +401,7 @@ about: - It may be because your code is too complex for all but a few people, and those people may not have realized your pull request even exists. A great way to find people who are qualified and care about the code you are touching is the - [Git Blame feature](https://docs.github.com/en/github/managing-files-in-a-repository/managing-files-on-github/tracking-changes-in-a-file). Simply + [Git Blame feature](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files). Simply look up who last modified the code you are changing and see if you can find them and give them a nudge. Don't be incessant about the nudging, though. - Finally, if all else fails, ask on IRC or elsewhere for someone to give your pull request diff --git a/doc/build-windows-msvc.md b/doc/build-windows-msvc.md index db51e6724d1..151c175031a 100644 --- a/doc/build-windows-msvc.md +++ b/doc/build-windows-msvc.md @@ -19,7 +19,7 @@ The former is assumed hereinafter. ### 2. Git -Download and install [Git for Windows](https://git-scm.com/download/win). Once installed, Git is available from PowerShell or the Command Prompt. +Download and install [Git for Windows](https://git-scm.com/downloads/win). Once installed, Git is available from PowerShell or the Command Prompt. ### 3. Clone Bitcoin Repository diff --git a/doc/files.md b/doc/files.md index 1b93ab797d1..6951331e297 100644 --- a/doc/files.md +++ b/doc/files.md @@ -98,7 +98,7 @@ Subdirectory | File | Description ## GUI settings -`bitcoin-qt` uses [`QSettings`](https://doc.qt.io/qt-5/qsettings.html) class; this implies platform-specific [locations where application settings are stored](https://doc.qt.io/qt-5/qsettings.html#locations-where-application-settings-are-stored). +`bitcoin-qt` uses [`QSettings`](https://doc.qt.io/qt-6/qsettings.html) class; this implies platform-specific [locations where application settings are stored](https://doc.qt.io/qt-6/qsettings.html#locations-where-application-settings-are-stored). ## Legacy subdirectories and files diff --git a/doc/tracing.md b/doc/tracing.md index 4f68d45a548..b9323589225 100644 --- a/doc/tracing.md +++ b/doc/tracing.md @@ -45,7 +45,7 @@ The two main eBPF front-ends with support for USDT are [bpftrace] and `bpftrace` is preferred for one-liners and shorter scripts. Examples for both can be found in [contrib/tracing]. -[bpftrace]: https://github.com/iovisor/bpftrace +[bpftrace]: https://github.com/bpftrace/bpftrace [BPF Compiler Collection (BCC)]: https://github.com/iovisor/bcc [contrib/tracing]: ../contrib/tracing/ diff --git a/doc/translation_process.md b/doc/translation_process.md index a9b2a116fda..2f113fe5b59 100644 --- a/doc/translation_process.md +++ b/doc/translation_process.md @@ -8,7 +8,7 @@ Transifex is setup to monitor the GitHub repo for updates, and when code contain Multiple language support is critical in assisting Bitcoin’s global adoption, and growth. One of Bitcoin’s greatest strengths is cross-border money transfers, any help making that easier is greatly appreciated. -See the [Transifex Bitcoin project](https://www.transifex.com/bitcoin/bitcoin/) to assist in translations. You should also join the translation mailing list for announcements - see details below. +See the [Transifex Bitcoin project](https://explore.transifex.com/bitcoin/bitcoin/) to assist in translations. You should also join the translation mailing list for announcements - see details below. ### Writing code with translations We use automated scripts to help extract translations in both Qt, and non-Qt source files. It is rarely necessary to manually edit the files in `src/qt/locale/`. The translation source files must adhere to the following format: @@ -39,9 +39,9 @@ git commit ``` ### Creating a Transifex account -Visit the [Transifex Signup](https://www.transifex.com/signup/) page to create an account. Take note of your username and password, as they will be required to configure the command-line tool. +Visit the [Transifex Signup](https://app.transifex.com/signup/open-source/) page to create an account. Take note of your username and password, as they will be required to configure the command-line tool. -You can find the Bitcoin translation project at [https://www.transifex.com/bitcoin/bitcoin/](https://www.transifex.com/bitcoin/bitcoin/). +You can find the Bitcoin translation project at [https://www.transifex.com/bitcoin/bitcoin/](https://explore.transifex.com/bitcoin/bitcoin/). ### Installing the Transifex client command-line tool The client is used to fetch updated translations. Please check installation instructions and any other details at https://developers.transifex.com/docs/cli. diff --git a/doc/zmq.md b/doc/zmq.md index 9637144d502..9fea2b41706 100644 --- a/doc/zmq.md +++ b/doc/zmq.md @@ -154,7 +154,7 @@ The 8-byte LE uints correspond to _mempool sequence number_ and the types of bod ### Implementing ZMQ client ZeroMQ endpoint specifiers for TCP (and others) are documented in the -[ZeroMQ API](http://api.zeromq.org/4-0:_start). +[ZeroMQ API](https://libzmq.readthedocs.io/en/zeromq4-x/). Client side, then, the ZeroMQ subscriber socket must have the ZMQ_SUBSCRIBE option set to one or either of these prefixes (for diff --git a/src/netaddress.cpp b/src/netaddress.cpp index ca562a96cae..7eb58f3ec86 100644 --- a/src/netaddress.cpp +++ b/src/netaddress.cpp @@ -182,7 +182,7 @@ bool CNetAddr::SetInternal(const std::string &name) } namespace torv3 { -// https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt?id=7116c9cdaba248aae07a3f1d0e15d9dd102f62c5#n2175 +// https://gitlab.torproject.org/tpo/core/torspec/-/tree/main/spec/rend-spec static constexpr size_t CHECKSUM_LEN = 2; static const unsigned char VERSION[] = {3}; static constexpr size_t TOTAL_LEN = ADDR_TORV3_SIZE + CHECKSUM_LEN + sizeof(VERSION); diff --git a/src/rpc/request.cpp b/src/rpc/request.cpp index 79cab2d8d25..e07072fd045 100644 --- a/src/rpc/request.cpp +++ b/src/rpc/request.cpp @@ -23,8 +23,8 @@ * but uses JSON-RPC 1.1/2.0 standards for parts of the 1.0 standard that were * unspecified (HTTP errors and contents of 'error'). * - * 1.0 spec: http://json-rpc.org/wiki/specification - * 1.2 spec: http://jsonrpc.org/historical/json-rpc-over-http.html + * 1.0 spec: https://www.jsonrpc.org/specification_v1 + * 1.2 spec: https://jsonrpc.org/historical/json-rpc-over-http.html * * If the server receives a request with the JSON-RPC 2.0 marker `{"jsonrpc": "2.0"}` * then Bitcoin will respond with a strictly specified response. @@ -35,7 +35,7 @@ * * 2.0 spec: https://www.jsonrpc.org/specification * - * Also see http://www.simple-is-better.org/rpc/#differences-between-1-0-and-2-0 + * Also see https://www.simple-is-better.org/rpc/#differences-between-1-0-and-2-0 */ UniValue JSONRPCRequestObj(const std::string& strMethod, const UniValue& params, const UniValue& id) diff --git a/src/test/data/tx_valid.json b/src/test/data/tx_valid.json index 70df0d0f697..d7c367b835c 100644 --- a/src/test/data/tx_valid.json +++ b/src/test/data/tx_valid.json @@ -7,7 +7,7 @@ ["The following is 23b397edccd3740a74adb603c9756370fafcde9bcc4483eb271ecad09a94dd63"], ["It is of particular interest because it contains an invalidly-encoded signature which OpenSSL accepts"], -["See http://r6.ca/blog/20111119T211504Z.html"], +["See https://r6.ca/blog/20111119T211504Z.html"], ["It is also the first OP_CHECKMULTISIG transaction in standard form"], [[["60a20bd93aa49ab4b28d514ec10b06e1829ce6818ec06cd3aabd013ebcdc4bb1", 0, "1 0x41 0x04cc71eb30d653c0c3163990c47b976f3fb3f37cccdcbedb169a1dfef58bbfbfaff7d8a473e7e2e6d317b87bafe8bde97e3cf8f065dec022b51d11fcdd0d348ac4 0x41 0x0461cbdcc5409fb4b4d42b51d33381354d80e550078cb532a34bfa2fcfdeb7d76519aecc62770f5b0e4ef8551946d8a540911abe3e7854a26f39f58b25c15342af 2 OP_CHECKMULTISIG"]], "0100000001b14bdcbc3e01bdaad36cc08e81e69c82e1060bc14e518db2b49aa43ad90ba26000000000490047304402203f16c6f40162ab686621ef3000b04e75418a0c0cb2d8aebeac894ae360ac1e780220ddc15ecdfc3507ac48e1681a33eb60996631bf6bf5bc0a0682c4db743ce7ca2b01ffffffff0140420f00000000001976a914660d4ef3a743e3e696ad990364e555c271ad504b88ac00000000", "DERSIG,LOW_S,STRICTENC"], diff --git a/src/validation.cpp b/src/validation.cpp index 9d9418c42b2..97190dc2486 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -2506,7 +2506,7 @@ bool Chainstate::ConnectBlock(const CBlock& block, BlockValidationState& state, // If such overwrites are allowed, coinbases and transactions depending upon those // can be duplicated to remove the ability to spend the first instance -- even after // being sent to another address. - // See BIP30, CVE-2012-1909, and http://r6.ca/blog/20120206T005236Z.html for more information. + // See BIP30, CVE-2012-1909, and https://r6.ca/blog/20120206T005236Z.html for more information. // This rule was originally applied to all blocks with a timestamp after March 15, 2012, 0:00 UTC. // Now that the whole chain is irreversibly beyond that time it is applied to all blocks except the // two in the chain that violate it. This prevents exploiting the issue against nodes during their