From f41d339b781f41f05946e965da3e1bf5d0a9e50b Mon Sep 17 00:00:00 2001 From: practicalswift Date: Sun, 3 Jun 2018 20:10:49 +0200 Subject: [PATCH] bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast(...) --- src/bench/bench_bitcoin.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp index 556d1fae9ed..f3302bfe5ad 100644 --- a/src/bench/bench_bitcoin.cpp +++ b/src/bench/bench_bitcoin.cpp @@ -6,11 +6,10 @@ #include #include -#include -#include #include - -#include +#include +#include +#include #include @@ -64,8 +63,11 @@ int main(int argc, char** argv) std::string scaling_str = gArgs.GetArg("-scaling", DEFAULT_BENCH_SCALING); bool is_list_only = gArgs.GetBoolArg("-list", false); - double scaling_factor = boost::lexical_cast(scaling_str); - + double scaling_factor; + if (!ParseDouble(scaling_str, &scaling_factor)) { + fprintf(stderr, "Error parsing scaling factor as double: %s\n", scaling_str.c_str()); + return EXIT_FAILURE; + } std::unique_ptr printer(new benchmark::ConsolePrinter()); std::string printer_arg = gArgs.GetArg("-printer", DEFAULT_BENCH_PRINTER);