From 6a936580d1c42576f627d5fac5423ec7af88e547 Mon Sep 17 00:00:00 2001 From: fanquake Date: Wed, 17 May 2023 10:53:47 +0100 Subject: [PATCH] ci: remove RUN_SECURITY_TESTS We no-longer run any security/syymbol checks in the CI, and doubt we will in future (if we do, it'll be via Guix, where this var would be redundant in any case). The CI environment doesn't (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don't match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953. --- ci/test/00_setup_env.sh | 1 - ci/test/06_script_b.sh | 4 ---- 2 files changed, 5 deletions(-) diff --git a/ci/test/00_setup_env.sh b/ci/test/00_setup_env.sh index 4a54f47b03f..d98f05ca6bc 100755 --- a/ci/test/00_setup_env.sh +++ b/ci/test/00_setup_env.sh @@ -37,7 +37,6 @@ export USE_BUSY_BOX=${USE_BUSY_BOX:-false} export RUN_UNIT_TESTS=${RUN_UNIT_TESTS:-true} export RUN_FUNCTIONAL_TESTS=${RUN_FUNCTIONAL_TESTS:-true} export RUN_TIDY=${RUN_TIDY:-false} -export RUN_SECURITY_TESTS=${RUN_SECURITY_TESTS:-false} # By how much to scale the test_runner timeouts (option --timeout-factor). # This is needed because some ci machines have slow CPU or disk, so sanitizers # might be slow or a reindex might be waiting on disk IO. diff --git a/ci/test/06_script_b.sh b/ci/test/06_script_b.sh index 075685ee8d0..d8fab1cc450 100755 --- a/ci/test/06_script_b.sh +++ b/ci/test/06_script_b.sh @@ -210,10 +210,6 @@ if [ "${RUN_TIDY}" = "true" ]; then git --no-pager diff fi -if [ "$RUN_SECURITY_TESTS" = "true" ]; then - make test-security-check -fi - if [ "$RUN_FUZZ_TESTS" = "true" ]; then bash -c "LD_LIBRARY_PATH=${DEPENDS_DIR}/${HOST}/lib test/fuzz/test_runner.py ${FUZZ_TESTS_CONFIG} $MAKEJOBS -l DEBUG ${DIR_FUZZ_IN}" fi