From fa02eb87df0b4a615a3e027711326f5506e5507a Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Wed, 15 Apr 2026 09:38:52 +0200 Subject: [PATCH] test: Add missing self.options.timeout_factor scale in tool_bitcoin_chainstate.py Apply the timeout factor inside the add_block function. Also, force named args for the two expected strings. Also, add trailing comma for style. --- test/functional/tool_bitcoin_chainstate.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/functional/tool_bitcoin_chainstate.py b/test/functional/tool_bitcoin_chainstate.py index 8f33da357be..c57da1fc376 100755 --- a/test/functional/tool_bitcoin_chainstate.py +++ b/test/functional/tool_bitcoin_chainstate.py @@ -51,15 +51,15 @@ class BitcoinChainstateTest(BitcoinTestFramework): assert_equal(n0.getbestblockhash(), SNAPSHOT_BASE_BLOCK_HASH) return n0.dumptxoutset('utxos.dat', "latest") - def add_block(self, datadir, input, expected_stderr=None, expected_stdout=None): + def add_block(self, datadir, input, *, expected_stderr=None, expected_stdout=None): proc = subprocess.Popen( self.get_binaries().chainstate_argv() + ["-regtest", datadir], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, - text=True + text=True, ) - stdout, stderr = proc.communicate(input=input + "\n", timeout=5) + stdout, stderr = proc.communicate(input=input + "\n", timeout=5 * self.options.timeout_factor) self.log.debug("STDOUT: {0}".format(stdout.strip("\n"))) self.log.info("STDERR: {0}".format(stderr.strip("\n")))