From fa54fb0129520c6aea1eab7628e12fbdd0ce8806 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Tue, 24 Mar 2026 15:51:08 +0100 Subject: [PATCH] refactor: gui: Accept up to nanoseconds in formatDurationStr, but clarify they are ignored This refactor does not change any behavior. However, it helps future commits to avoid having to place manual std::chrono::duration_cast when calling this function. --- src/qt/guiutil.cpp | 2 +- src/qt/guiutil.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp index 9fd46cfc1e1..9cdfe2bcd24 100644 --- a/src/qt/guiutil.cpp +++ b/src/qt/guiutil.cpp @@ -728,7 +728,7 @@ QString ConnectionTypeToQString(ConnectionType conn_type, bool prepend_direction assert(false); } -QString formatDurationStr(std::chrono::seconds dur) +QString formatDurationStr(std::chrono::nanoseconds dur) { const auto d{std::chrono::duration_cast(dur)}; const auto h{std::chrono::duration_cast(dur - d)}; diff --git a/src/qt/guiutil.h b/src/qt/guiutil.h index bcde397d7ba..f34c4eac181 100644 --- a/src/qt/guiutil.h +++ b/src/qt/guiutil.h @@ -228,8 +228,8 @@ namespace GUIUtil /** Convert enum ConnectionType to QString */ QString ConnectionTypeToQString(ConnectionType conn_type, bool prepend_direction); - /** Convert seconds into a QString with days, hours, mins, secs */ - QString formatDurationStr(std::chrono::seconds dur); + /// Convert a duration into a QString with days, hours, mins, secs. This ignores sub-seconds. + QString formatDurationStr(std::chrono::nanoseconds dur); /** Convert peer connection time to a QString denominated in the most relevant unit. */ QString FormatPeerAge(std::chrono::seconds time_connected);