diff --git a/src/netbase.cpp b/src/netbase.cpp index 1a96443d4a7..a6de72090e6 100644 --- a/src/netbase.cpp +++ b/src/netbase.cpp @@ -557,7 +557,8 @@ std::unique_ptr CreateSockOS(int domain, int type, int protocol) std::function(int, int, int)> CreateSock = CreateSockOS; template -static void LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args) { +static void LogConnectFailure(bool manual_connection, util::ConstevalFormatString fmt, const Args&... args) +{ std::string error_message = tfm::format(fmt, args...); if (manual_connection) { LogPrintf("%s\n", error_message); diff --git a/test/lint/lint-format-strings.py b/test/lint/lint-format-strings.py index 5dbad3f452f..c30975fea7f 100755 --- a/test/lint/lint-format-strings.py +++ b/test/lint/lint-format-strings.py @@ -17,7 +17,6 @@ import sys FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [ 'tfm::format,1', # Assuming tfm::::format(std::ostream&, ... - 'LogConnectFailure,1', 'LogError,0', 'LogWarning,0', 'LogInfo,0', diff --git a/test/lint/run-lint-format-strings.py b/test/lint/run-lint-format-strings.py index f78f356a349..a32717653aa 100755 --- a/test/lint/run-lint-format-strings.py +++ b/test/lint/run-lint-format-strings.py @@ -13,7 +13,6 @@ import re import sys FALSE_POSITIVES = [ - ("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"), ("src/clientversion.cpp", "strprintf(_(COPYRIGHT_HOLDERS).translated, COPYRIGHT_HOLDERS_SUBSTITUTION)"), ("src/test/translation_tests.cpp", "strprintf(format, arg)"), ("src/validationinterface.cpp", "LogDebug(BCLog::VALIDATION, fmt \"\\n\", __VA_ARGS__)"),