From fa955af6181fe04f715076d5259bb9e76368ef12 Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Wed, 1 Apr 2026 10:24:32 +0200
Subject: [PATCH] lint: Clarify rmtree/remove_all error message with preferred
 alternatives

---
 test/lint/test_runner/src/lint_cpp.rs | 3 ++-
 test/lint/test_runner/src/lint_py.rs  | 4 ++--
 test/lint/test_runner/src/main.rs     | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/test/lint/test_runner/src/lint_cpp.rs b/test/lint/test_runner/src/lint_cpp.rs
index e587c4c03e3..727c87584df 100644
--- a/test/lint/test_runner/src/lint_cpp.rs
+++ b/test/lint/test_runner/src/lint_cpp.rs
@@ -139,7 +139,8 @@ pub fn lint_remove_all() -> LintResult {
         .success();
     if found {
         Err(r#"
-Use of fs::remove_all or std::filesystem::remove_all is dangerous and should be avoided.
+Use of fs::remove_all or std::filesystem::remove_all is dangerous and should be avoided. If removal
+is required, prefer fs::remove.
             "#
         .trim()
         .to_string())
diff --git a/test/lint/test_runner/src/lint_py.rs b/test/lint/test_runner/src/lint_py.rs
index a335ba27bcd..7c5c0dae5a6 100644
--- a/test/lint/test_runner/src/lint_py.rs
+++ b/test/lint/test_runner/src/lint_py.rs
@@ -89,7 +89,8 @@ pub fn lint_rmtree() -> LintResult {
         .success();
     if found {
         Err(r#"
-Use of shutil.rmtree() is dangerous and should be avoided.
+Use of shutil.rmtree() is dangerous and should be avoided. If it
+is really required for the test, use self.cleanup_folder(_).
             "#
         .trim()
         .to_string())
@@ -97,4 +98,3 @@ Use of shutil.rmtree() is dangerous and should be avoided.
         Ok(())
     }
 }
-
diff --git a/test/lint/test_runner/src/main.rs b/test/lint/test_runner/src/main.rs
index 8d34fc6e24c..7c0eb585893 100644
--- a/test/lint/test_runner/src/main.rs
+++ b/test/lint/test_runner/src/main.rs
@@ -14,7 +14,8 @@ use std::fs;
 use std::process::{Command, ExitCode};
 
 use lint_cpp::{
-    lint_boost_assert, lint_includes_build_config, lint_remove_all, lint_rpc_assert, lint_std_filesystem,
+    lint_boost_assert, lint_includes_build_config, lint_remove_all, lint_rpc_assert,
+    lint_std_filesystem,
 };
 use lint_docs::{lint_doc_args, lint_doc_release_note_snippets, lint_markdown};
 use lint_py::{lint_py_lint, lint_rmtree};